Title: [221220] trunk/Tools
Revision
221220
Author
[email protected]
Date
2017-08-25 19:49:55 -0700 (Fri, 25 Aug 2017)

Log Message

Disable saveDataToFile API test.
https://bugs.webkit.org/show_bug.cgi?id=176000

* TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
The test was only working on High Sierra.  It needs investigation on older operating systems.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (221219 => 221220)


--- trunk/Tools/ChangeLog	2017-08-26 01:43:56 UTC (rev 221219)
+++ trunk/Tools/ChangeLog	2017-08-26 02:49:55 UTC (rev 221220)
@@ -1,5 +1,13 @@
 2017-08-25  Alex Christensen  <[email protected]>
 
+        Disable saveDataToFile API test.
+        https://bugs.webkit.org/show_bug.cgi?id=176000
+
+        * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
+        The test was only working on High Sierra.  It needs investigation on older operating systems.
+
+2017-08-25  Alex Christensen  <[email protected]>
+
         Rename TestWebKitAPI/Tests/WebKit2* to WebKit* following Source directory rename.
 
         Rubber-stamped by Brady Eidson.

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm (221219 => 221220)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm	2017-08-26 01:43:56 UTC (rev 221219)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm	2017-08-26 02:49:55 UTC (rev 221220)
@@ -133,6 +133,11 @@
     ASSERT_EQ(takenDirection, _WKFocusDirectionBackward);
 }
 
+#define MOUSE_EVENT_CAUSES_DOWNLOAD 0
+// FIXME: At least on El Capitan, sending a mouse event does not cause the PDFPlugin to think the download button has been clicked.
+// This test works on High Sierra, but it should be investigated on older platforms.
+#if MOUSE_EVENT_CAUSES_DOWNLOAD
+
 @interface SaveDataToFileDelegate : NSObject <WKUIDelegatePrivate, WKNavigationDelegate>
 @end
 
@@ -168,6 +173,8 @@
     TestWebKitAPI::Util::run(&done);
 }
 
+#endif // MOUSE_EVENT_CAUSES_DOWNLOAD
+
 #define RELIABLE_DID_NOT_HANDLE_WHEEL_EVENT 0
 // FIXME: make wheel event handling more reliable.
 // https://bugs.webkit.org/show_bug.cgi?id=175967
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to