Title: [221323] trunk/Source/WTF
- Revision
- 221323
- Author
- pvol...@apple.com
- Date
- 2017-08-29 16:35:33 -0700 (Tue, 29 Aug 2017)
Log Message
[Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=176064
Reviewed by Saam Barati.
The crash log indicates that the function pointer is null in this case.
* wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::dispatch):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (221322 => 221323)
--- trunk/Source/WTF/ChangeLog 2017-08-29 23:32:43 UTC (rev 221322)
+++ trunk/Source/WTF/ChangeLog 2017-08-29 23:35:33 UTC (rev 221323)
@@ -1,3 +1,15 @@
+2017-08-29 Per Arne Vollan <pvol...@apple.com>
+
+ [Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
+ https://bugs.webkit.org/show_bug.cgi?id=176064
+
+ Reviewed by Saam Barati.
+
+ The crash log indicates that the function pointer is null in this case.
+
+ * wtf/win/WorkQueueWin.cpp:
+ (WTF::WorkQueue::dispatch):
+
2017-08-28 Andy Estes <aes...@apple.com>
[Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
Modified: trunk/Source/WTF/wtf/win/WorkQueueWin.cpp (221322 => 221323)
--- trunk/Source/WTF/wtf/win/WorkQueueWin.cpp 2017-08-29 23:32:43 UTC (rev 221322)
+++ trunk/Source/WTF/wtf/win/WorkQueueWin.cpp 2017-08-29 23:35:33 UTC (rev 221323)
@@ -100,6 +100,12 @@
void WorkQueue::dispatch(Function<void()>&& function)
{
+ // FIXME: During layout tests, this method is sometimes called with a nullptr function parameter.
+ // This is tracked in <http://webkit.org/b/176072>.
+ ASSERT(function);
+ if (!function)
+ return;
+
MutexLocker locker(m_functionQueueLock);
ref();
m_functionQueue.append(WTFMove(function));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
