Title: [221438] trunk/Source/WebCore
Revision
221438
Author
mcatanz...@igalia.com
Date
2017-08-31 13:09:53 -0700 (Thu, 31 Aug 2017)

Log Message

REGRESSION(r221226): [SOUP] libsoup-CRITICAL **: soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=176140

Reviewed by Carlos Garcia Campos.

This should fix unexpected stderr output in several tests.

* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookiesForSession):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (221437 => 221438)


--- trunk/Source/WebCore/ChangeLog	2017-08-31 20:03:42 UTC (rev 221437)
+++ trunk/Source/WebCore/ChangeLog	2017-08-31 20:09:53 UTC (rev 221438)
@@ -1,3 +1,15 @@
+2017-08-31  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        REGRESSION(r221226): [SOUP] libsoup-CRITICAL **: soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed
+        https://bugs.webkit.org/show_bug.cgi?id=176140
+
+        Reviewed by Carlos Garcia Campos.
+
+        This should fix unexpected stderr output in several tests.
+
+        * platform/network/soup/CookieJarSoup.cpp:
+        (WebCore::cookiesForSession):
+
 2017-08-31  Youenn Fablet  <you...@apple.com>
 
         Add support for Request body stream cloning

Modified: trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp (221437 => 221438)


--- trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp	2017-08-31 20:03:42 UTC (rev 221437)
+++ trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp	2017-08-31 20:09:53 UTC (rev 221438)
@@ -107,6 +107,9 @@
         }
     }
 
+    if (!cookies)
+        return { { }, false };
+
     GUniquePtr<char> cookieHeader(soup_cookies_to_cookie_header(cookies));
     soup_cookies_free(cookies);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to