Title: [221656] trunk/Tools
- Revision
- 221656
- Author
- commit-qu...@webkit.org
- Date
- 2017-09-05 18:01:36 -0700 (Tue, 05 Sep 2017)
Log Message
Benchmark Runner WebDriver maximize window on browser launch
https://bugs.webkit.org/show_bug.cgi?id=175702
Patch by Matthew Stewart <matthew_r_stew...@apple.com> on 2017-09-05
Reviewed by Stephanie Lewis.
* Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
(LinuxBrowserDriver.launch_webdriver): added driver.maximize_window()
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver._launch_webdriver): added driver.maximize_window()
* Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
(WebDriverBenchmarkRunner._run_one_test): added driver.quit()
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (221655 => 221656)
--- trunk/Tools/ChangeLog 2017-09-06 01:00:48 UTC (rev 221655)
+++ trunk/Tools/ChangeLog 2017-09-06 01:01:36 UTC (rev 221656)
@@ -1,5 +1,19 @@
2017-09-05 Matthew Stewart <matthew_r_stew...@apple.com>
+ Benchmark Runner WebDriver maximize window on browser launch
+ https://bugs.webkit.org/show_bug.cgi?id=175702
+
+ Reviewed by Stephanie Lewis.
+
+ * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
+ (LinuxBrowserDriver.launch_webdriver): added driver.maximize_window()
+ * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
+ (OSXBrowserDriver._launch_webdriver): added driver.maximize_window()
+ * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
+ (WebDriverBenchmarkRunner._run_one_test): added driver.quit()
+
+2017-09-05 Matthew Stewart <matthew_r_stew...@apple.com>
+
Fix Benchmark Runner selenium autoinstall imports
https://bugs.webkit.org/show_bug.cgi?id=175727
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py (221655 => 221656)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py 2017-09-06 01:00:48 UTC (rev 221655)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py 2017-09-06 01:01:36 UTC (rev 221656)
@@ -98,6 +98,10 @@
stderr=subprocess.STDOUT)
def launch_webdriver(self, url, driver):
+ try:
+ driver.maximize_window()
+ except Exception as error:
+ _log.error('Failed to maximize {browser} window - Error: {error}'.format(browser=driver.name, error=error))
_log.info('Launching "%s" with url "%s"' % (driver.name, url))
driver.get(url)
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py (221655 => 221656)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py 2017-09-06 01:00:48 UTC (rev 221655)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py 2017-09-06 01:01:36 UTC (rev 221656)
@@ -44,6 +44,10 @@
@classmethod
def _launch_webdriver(cls, url, driver):
+ try:
+ driver.maximize_window()
+ except Exception as error:
+ _log.error('Failed to maximize {browser} window - Error: {error}'.format(browser=driver.name, error=error))
_log.info('Launching "%s" with url "%s"' % (driver.name, url))
driver.get(url)
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py (221655 => 221656)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py 2017-09-06 01:00:48 UTC (rev 221655)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py 2017-09-06 01:01:36 UTC (rev 221656)
@@ -25,6 +25,7 @@
driver = self._browser_driver.launch_driver(url, self._plan['options'], self._build_dir)
_log.info('Waiting on results from web browser')
result = WebDriverWait(driver, self._plan['timeout'], poll_frequency=1.0).until(self._get_result)
+ driver.quit()
finally:
self._browser_driver.close_browsers()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
