Title: [221800] trunk/Source/WebInspectorUI
- Revision
- 221800
- Author
- [email protected]
- Date
- 2017-09-08 15:09:17 -0700 (Fri, 08 Sep 2017)
Log Message
Uncaught Exception: TypeError: this._heapSnapshot.addEventListener is not a function.
https://bugs.webkit.org/show_bug.cgi?id=176633
Patch by Joseph Pecoraro <[email protected]> on 2017-09-08
Reviewed by Michael Saboff.
* UserInterface/Proxies/HeapSnapshotDiffProxy.js:
(WI.HeapSnapshotDiffProxy):
This class has listeners of another object's events. It should extend WI.Object.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (221799 => 221800)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-09-08 21:27:04 UTC (rev 221799)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-09-08 22:09:17 UTC (rev 221800)
@@ -1,3 +1,14 @@
+2017-09-08 Joseph Pecoraro <[email protected]>
+
+ Uncaught Exception: TypeError: this._heapSnapshot.addEventListener is not a function.
+ https://bugs.webkit.org/show_bug.cgi?id=176633
+
+ Reviewed by Michael Saboff.
+
+ * UserInterface/Proxies/HeapSnapshotDiffProxy.js:
+ (WI.HeapSnapshotDiffProxy):
+ This class has listeners of another object's events. It should extend WI.Object.
+
2017-09-08 Devin Rousso <[email protected]>
Web Inspector: Canvas: changes to currentX/currentY aren't highlighted in the details sidebar
Modified: trunk/Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotDiffProxy.js (221799 => 221800)
--- trunk/Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotDiffProxy.js 2017-09-08 21:27:04 UTC (rev 221799)
+++ trunk/Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotDiffProxy.js 2017-09-08 22:09:17 UTC (rev 221800)
@@ -23,10 +23,12 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-WI.HeapSnapshotDiffProxy = class HeapSnapshotDiffProxy
+WI.HeapSnapshotDiffProxy = class HeapSnapshotDiffProxy extends WI.Object
{
constructor(snapshotDiffObjectId, snapshot1, snapshot2, totalSize, totalObjectCount, categories)
{
+ super();
+
this._proxyObjectId = snapshotDiffObjectId;
console.assert(snapshot1 instanceof WI.HeapSnapshotProxy);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
