Diff
Modified: trunk/LayoutTests/ChangeLog (221949 => 221950)
--- trunk/LayoutTests/ChangeLog 2017-09-13 00:20:36 UTC (rev 221949)
+++ trunk/LayoutTests/ChangeLog 2017-09-13 00:27:46 UTC (rev 221950)
@@ -1,3 +1,13 @@
+2017-09-12 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ Unskip fast/text/system-font-synthetic-italic.html
+ https://bugs.webkit.org/show_bug.cgi?id=175944
+ <rdar://problem/32864306>
+
+ Reviewed by Jon Lee.
+
+ * platform/mac-highsierra/TestExpectations:
+
2017-09-12 Michael Saboff <msab...@apple.com>
String.prototype.replace() puts extra '<' in result when a named capture reference is used without named captures in the RegExp
Modified: trunk/LayoutTests/platform/mac-highsierra/TestExpectations (221949 => 221950)
--- trunk/LayoutTests/platform/mac-highsierra/TestExpectations 2017-09-13 00:20:36 UTC (rev 221949)
+++ trunk/LayoutTests/platform/mac-highsierra/TestExpectations 2017-09-13 00:27:46 UTC (rev 221950)
@@ -121,9 +121,6 @@
# <rdar://problem/32826391> LayoutTest imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm is failing on High Sierra
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm [ Failure ]
-# <rdar://problem/32864306> Unskip after bots have CTFontCopyPhysicalFont()
-fast/text/system-font-japanese-synthetic-italic.html [ Pass ImageOnlyFailure ]
-
# This test makes sure that variation fonts are disabled on OSes which don't support them. So,
# the test should be skipped on OSes which do support them. As soon as all OSes support them,
# we should delete the test.
Modified: trunk/Source/WebCore/ChangeLog (221949 => 221950)
--- trunk/Source/WebCore/ChangeLog 2017-09-13 00:20:36 UTC (rev 221949)
+++ trunk/Source/WebCore/ChangeLog 2017-09-13 00:27:46 UTC (rev 221950)
@@ -1,5 +1,18 @@
2017-09-12 Myles C. Maxfield <mmaxfi...@apple.com>
+ Unskip fast/text/system-font-synthetic-italic.html
+ https://bugs.webkit.org/show_bug.cgi?id=175944
+ <rdar://problem/32864306>
+
+ Reviewed by Jon Lee.
+
+ Our buildbots now all have this symbol.
+
+ * platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:
+ (WebCore::FontFamilySpecificationCoreText::fontRanges const):
+
+2017-09-12 Myles C. Maxfield <mmaxfi...@apple.com>
+
ASSERTION FAILED: !m_valueOrException under FontFaceSet::completedLoading loading a Serious Eats page
https://bugs.webkit.org/show_bug.cgi?id=175899
Modified: trunk/Source/WebCore/PAL/ChangeLog (221949 => 221950)
--- trunk/Source/WebCore/PAL/ChangeLog 2017-09-13 00:20:36 UTC (rev 221949)
+++ trunk/Source/WebCore/PAL/ChangeLog 2017-09-13 00:27:46 UTC (rev 221950)
@@ -1,3 +1,12 @@
+2017-09-12 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ Unskip fast/text/system-font-synthetic-italic.html
+ https://bugs.webkit.org/show_bug.cgi?id=175944
+
+ Reviewed by Jon Lee.
+
+ * pal/spi/cocoa/CoreTextSPI.h:
+
2017-09-12 Eric Carlson <eric.carl...@apple.com>
Switch MediaPlayerPrivateAVFoundation to release logging
Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h (221949 => 221950)
--- trunk/Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h 2017-09-13 00:20:36 UTC (rev 221949)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h 2017-09-13 00:27:46 UTC (rev 221950)
@@ -93,6 +93,7 @@
bool CTFontDescriptorIsSystemUIFont(CTFontDescriptorRef);
CTFontRef CTFontCreateForCSS(CFStringRef name, uint16_t weight, CTFontSymbolicTraits, CGFloat size);
CTFontRef CTFontCreateForCharactersWithLanguage(CTFontRef currentFont, const UTF16Char *characters, CFIndex length, CFStringRef language, CFIndex *coveredLength);
+CTFontRef CTFontCopyPhysicalFont(CTFontRef);
extern const CFStringRef kCTUIFontTextStyleShortHeadline;
extern const CFStringRef kCTUIFontTextStyleShortBody;
Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp (221949 => 221950)
--- trunk/Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp 2017-09-13 00:20:36 UTC (rev 221949)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp 2017-09-13 00:27:46 UTC (rev 221950)
@@ -26,16 +26,12 @@
#include "config.h"
#include "FontFamilySpecificationCoreText.h"
+#include <pal/spi/cocoa/CoreTextSPI.h>
#include "FontCache.h"
#include "FontSelector.h"
+
#include <CoreText/CoreText.h>
-#include <wtf/SoftLinking.h>
-#if USE_PLATFORM_SYSTEM_FALLBACK_LIST
-SOFT_LINK_FRAMEWORK(CoreText);
-SOFT_LINK_MAY_FAIL(CoreText, CTFontCopyPhysicalFont, CTFontRef, (CTFontRef font), (font));
-#endif
-
namespace WebCore {
FontFamilySpecificationCoreText::FontFamilySpecificationCoreText(CTFontDescriptorRef fontDescriptor)
@@ -55,10 +51,8 @@
auto fontForSynthesisComputation = font;
#if USE_PLATFORM_SYSTEM_FALLBACK_LIST
- if (canLoadCTFontCopyPhysicalFont()) {
- if (auto physicalFont = adoptCF(CTFontCopyPhysicalFont(font.get())))
- fontForSynthesisComputation = physicalFont;
- }
+ if (auto physicalFont = adoptCF(CTFontCopyPhysicalFont(font.get())))
+ fontForSynthesisComputation = physicalFont;
#endif
font = preparePlatformFont(font.get(), fontDescription, nullptr, nullptr, { }, fontDescription.computedSize());
