Title: [222557] trunk/Source/WebCore
- Revision
- 222557
- Author
- [email protected]
- Date
- 2017-09-27 10:08:58 -0700 (Wed, 27 Sep 2017)
Log Message
Ref element keys in CSSAnimationControllerPrivate
https://bugs.webkit.org/show_bug.cgi?id=177543
Reviewed by Zalan Bujtas.
For safety.
* page/animation/CSSAnimationControllerPrivate.h:
This won't create ref cycle as elements are removed from the m_compositeAnimations maps when they
are removed from the tree. We have assertions that verify the map is always cleared.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (222556 => 222557)
--- trunk/Source/WebCore/ChangeLog 2017-09-27 16:19:08 UTC (rev 222556)
+++ trunk/Source/WebCore/ChangeLog 2017-09-27 17:08:58 UTC (rev 222557)
@@ -1,3 +1,17 @@
+2017-09-27 Antti Koivisto <[email protected]>
+
+ Ref element keys in CSSAnimationControllerPrivate
+ https://bugs.webkit.org/show_bug.cgi?id=177543
+
+ Reviewed by Zalan Bujtas.
+
+ For safety.
+
+ * page/animation/CSSAnimationControllerPrivate.h:
+
+ This won't create ref cycle as elements are removed from the m_compositeAnimations maps when they
+ are removed from the tree. We have assertions that verify the map is always cleared.
+
2017-09-27 David Hyatt <[email protected]>
Rename "Region" to "Fragment" for RenderRegion and associated classes/methods.
Modified: trunk/Source/WebCore/page/animation/CSSAnimationControllerPrivate.h (222556 => 222557)
--- trunk/Source/WebCore/page/animation/CSSAnimationControllerPrivate.h 2017-09-27 16:19:08 UTC (rev 222556)
+++ trunk/Source/WebCore/page/animation/CSSAnimationControllerPrivate.h 2017-09-27 17:08:58 UTC (rev 222557)
@@ -124,7 +124,7 @@
void fireEventsAndUpdateStyle();
void startTimeResponse(double t);
- HashMap<Element*, RefPtr<CompositeAnimation>> m_compositeAnimations;
+ HashMap<RefPtr<Element>, RefPtr<CompositeAnimation>> m_compositeAnimations;
Timer m_animationTimer;
Timer m_updateStyleIfNeededDispatcher;
Frame& m_frame;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
