Title: [222777] trunk
- Revision
- 222777
- Author
- ryanhad...@apple.com
- Date
- 2017-10-03 08:19:01 -0700 (Tue, 03 Oct 2017)
Log Message
Unreviewed, rolling out r222760.
This change caused LayoutTest crashes.
Reverted changeset:
"[Mac] Use safer decoding practices for NSKeyedUnarchiver"
https://bugs.webkit.org/show_bug.cgi?id=175887
http://trac.webkit.org/changeset/222760
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (222776 => 222777)
--- trunk/LayoutTests/ChangeLog 2017-10-03 09:50:06 UTC (rev 222776)
+++ trunk/LayoutTests/ChangeLog 2017-10-03 15:19:01 UTC (rev 222777)
@@ -1,3 +1,15 @@
+2017-10-03 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, rolling out r222760.
+
+ This change caused LayoutTest crashes.
+
+ Reverted changeset:
+
+ "[Mac] Use safer decoding practices for NSKeyedUnarchiver"
+ https://bugs.webkit.org/show_bug.cgi?id=175887
+ http://trac.webkit.org/changeset/222760
+
2017-10-03 Michael Catanzaro <mcatanz...@igalia.com>
REGRESSION(r222392): [WPE][GTK] Many forms tests are failing due to broken event timestamps
Modified: trunk/LayoutTests/platform/ios/TestExpectations (222776 => 222777)
--- trunk/LayoutTests/platform/ios/TestExpectations 2017-10-03 09:50:06 UTC (rev 222776)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2017-10-03 15:19:01 UTC (rev 222777)
@@ -1128,10 +1128,6 @@
webarchive/test-css-url-resources-inline-styles.html [ Failure ]
webarchive/test-link-rel-icon.html [ Failure ]
-# The following two tests are expected to fail until <rdar://problem/34063313> is available on test systems.
-webarchive/loading/cache-expired-subresource.html [ Failure ]
-webarchive/loading/test-loading-archive-subresource-null-mimetype.html [ Crash ]
-
# Webarchive tests that fail due to <https://bugs.webkit.org/show_bug.cgi?id=82665>:
http/tests/webarchive/test-css-url-encoding-shift-jis.html
http/tests/webarchive/test-css-url-encoding-utf-8.html
Modified: trunk/LayoutTests/platform/mac/TestExpectations (222776 => 222777)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-10-03 09:50:06 UTC (rev 222776)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-10-03 15:19:01 UTC (rev 222777)
@@ -209,10 +209,6 @@
webkit.org/b/56685 webarchive/test-link-rel-icon.html [ Failure ]
-# The following two tests are expected to fail until <rdar://problem/34063313> is available on test systems.
-webarchive/loading/cache-expired-subresource.html [ Failure ]
-webarchive/loading/test-loading-archive-subresource-null-mimetype.html [ Crash ]
-
# Quota API is not supported.
storage/storageinfo-missing-arguments.html
storage/storageinfo-no-callbacks.html
Modified: trunk/Source/WebCore/ChangeLog (222776 => 222777)
--- trunk/Source/WebCore/ChangeLog 2017-10-03 09:50:06 UTC (rev 222776)
+++ trunk/Source/WebCore/ChangeLog 2017-10-03 15:19:01 UTC (rev 222777)
@@ -1,3 +1,15 @@
+2017-10-03 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, rolling out r222760.
+
+ This change caused LayoutTest crashes.
+
+ Reverted changeset:
+
+ "[Mac] Use safer decoding practices for NSKeyedUnarchiver"
+ https://bugs.webkit.org/show_bug.cgi?id=175887
+ http://trac.webkit.org/changeset/222760
+
2017-10-03 Michael Catanzaro <mcatanz...@igalia.com>
REGRESSION(r222392): [WPE][GTK] Many forms tests are failing due to broken event timestamps
Modified: trunk/Source/WebCore/loader/archive/cf/LegacyWebArchiveMac.mm (222776 => 222777)
--- trunk/Source/WebCore/loader/archive/cf/LegacyWebArchiveMac.mm 2017-10-03 09:50:06 UTC (rev 222776)
+++ trunk/Source/WebCore/loader/archive/cf/LegacyWebArchiveMac.mm 2017-10-03 15:19:01 UTC (rev 222777)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2008-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -43,20 +43,12 @@
NSURLResponse *response = nil;
NSKeyedUnarchiver *unarchiver = [[NSKeyedUnarchiver alloc] initForReadingWithData:(NSData *)responseData];
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || PLATFORM(IOS)
- // Because of <rdar://problem/34063313> we can't use this for decoding in older OS's.
- [unarchiver setRequiresSecureCoding:YES];
@try {
- response = [unarchiver decodeObjectOfClass:[NSURLResponse class] forKey:LegacyWebArchiveResourceResponseKey];
-#else
- @try {
id responseObject = [unarchiver decodeObjectForKey:LegacyWebArchiveResourceResponseKey];
if ([responseObject isKindOfClass:[NSURLResponse class]])
response = responseObject;
-#endif
[unarchiver finishDecoding];
- } @catch (NSException *exception) {
- LOG_ERROR("Failed to decode NS(HTTP)URLResponse: %@", exception);
+ } @catch(id) {
response = nil;
}
[unarchiver release];
@@ -74,7 +66,6 @@
CFMutableDataRef responseData = CFDataCreateMutable(0, 0);
NSKeyedArchiver *archiver = [[NSKeyedArchiver alloc] initForWritingWithMutableData:(NSMutableData *)responseData];
- [archiver setRequiresSecureCoding:YES];
[archiver encodeObject:nsResponse forKey:LegacyWebArchiveResourceResponseKey];
[archiver finishEncoding];
[archiver release];
Modified: trunk/Source/WebCore/testing/cocoa/WebArchiveDumpSupport.mm (222776 => 222777)
--- trunk/Source/WebCore/testing/cocoa/WebArchiveDumpSupport.mm 2017-10-03 09:50:06 UTC (rev 222776)
+++ trunk/Source/WebCore/testing/cocoa/WebArchiveDumpSupport.mm 2017-10-03 15:19:01 UTC (rev 222777)
@@ -41,19 +41,8 @@
static CFURLResponseRef createCFURLResponseFromResponseData(CFDataRef responseData)
{
RetainPtr<NSKeyedUnarchiver> unarchiver = adoptNS([[NSKeyedUnarchiver alloc] initForReadingWithData:(NSData *)responseData]);
- [unarchiver setRequiresSecureCoding:YES];
- NSURLResponse *response;
- @try {
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || PLATFORM(IOS)
- response = [unarchiver decodeObjectOfClass:[NSURLResponse class] forKey:@"WebResourceResponse"]; // WebResourceResponseKey in WebResource.m
-#else
- response = [unarchiver decodeObjectForKey:@"WebResourceResponse"]; // WebResourceResponseKey in WebResource.m
-#endif
- [unarchiver finishDecoding];
- } @catch (NSException *exception) {
- LOG_ERROR("Failed to decode NS(HTTP)URLResponse: %@", exception);
- response = nil;
- }
+ NSURLResponse *response = [unarchiver decodeObjectForKey:@"WebResourceResponse"]; // WebResourceResponseKey in WebResource.m
+ [unarchiver finishDecoding];
if (![response isKindOfClass:[NSHTTPURLResponse class]])
return CFURLResponseCreate(kCFAllocatorDefault, (CFURLRef)response.URL, (CFStringRef)response.MIMEType, response.expectedContentLength, (CFStringRef)response.textEncodingName, kCFURLCacheStorageAllowed);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
