Title: [223177] trunk/Tools
Revision
223177
Author
tpop...@redhat.com
Date
2017-10-11 06:59:44 -0700 (Wed, 11 Oct 2017)

Log Message

Use https for trac changeset and browser links
https://bugs.webkit.org/show_bug.cgi?id=178167

Reviewed by Alexey Proskuryakov.

Switch the http://trac.webkit.org/changeset and
http://trac.webkit.org/browser links that are printed by webkitpy to
https. Also update the test expectations.

* Scripts/webkitpy/common/checkout/checkout_unittest.py:
* Scripts/webkitpy/common/config/committervalidator_unittest.py:
(CommitterValidatorTest.test_flag_permission_rejection_message):
* Scripts/webkitpy/common/config/urls.py:
(view_source_url):
(view_revision_url):
* Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
(BugTest.test_commit_revision):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.test_missing_bug_number):
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_rollout):
(IRCBotTest.test_revert):
(IRCBotTest.test_multi_rollout):
(IRCBotTest.test_rollout_with_r_in_svn_revision):
(IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
(IRCBotTest.test_rollout_invalidate_reason):
(test_multi_rollout_invalidate_reason):
* Scripts/webkitpy/tool/bot/sheriff_unittest.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/suggestnominations.py:
(SuggestNominations._count_commit):
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js:
(getTracUrl):
(getSortedKeys):
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
(CloseBugForLandDiffTest.test_empty_state):
* Scripts/webkitpy/tool/steps/commit_unittest.py:
(CommitTest._test_check_test_expectations):
* Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
(UpdateChangeLogsForRevertTest):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (223176 => 223177)


--- trunk/Tools/ChangeLog	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/ChangeLog	2017-10-11 13:59:44 UTC (rev 223177)
@@ -1,3 +1,56 @@
+2017-10-11  Tomas Popela  <tpop...@redhat.com>
+
+        Use https for trac changeset and browser links
+        https://bugs.webkit.org/show_bug.cgi?id=178167
+
+        Reviewed by Alexey Proskuryakov.
+
+        Switch the http://trac.webkit.org/changeset and
+        http://trac.webkit.org/browser links that are printed by webkitpy to
+        https. Also update the test expectations.
+
+        * Scripts/webkitpy/common/checkout/checkout_unittest.py:
+        * Scripts/webkitpy/common/config/committervalidator_unittest.py:
+        (CommitterValidatorTest.test_flag_permission_rejection_message):
+        * Scripts/webkitpy/common/config/urls.py:
+        (view_source_url):
+        (view_revision_url):
+        * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
+        (BugTest.test_commit_revision):
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
+        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
+        * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
+        (MainTest):
+        (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
+        * Scripts/webkitpy/style/checkers/changelog_unittest.py:
+        (ChangeLogCheckerTest.test_missing_bug_number):
+        * Scripts/webkitpy/tool/bot/feeders_unittest.py:
+        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
+        * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
+        (IRCBotTest.test_rollout):
+        (IRCBotTest.test_revert):
+        (IRCBotTest.test_multi_rollout):
+        (IRCBotTest.test_rollout_with_r_in_svn_revision):
+        (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
+        (IRCBotTest.test_rollout_invalidate_reason):
+        (test_multi_rollout_invalidate_reason):
+        * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
+        * Scripts/webkitpy/tool/commands/download_unittest.py:
+        * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
+        * Scripts/webkitpy/tool/commands/queues_unittest.py:
+        * Scripts/webkitpy/tool/commands/suggestnominations.py:
+        (SuggestNominations._count_commit):
+        * Scripts/webkitpy/tool/commands/upload_unittest.py:
+        * Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js:
+        (getTracUrl):
+        (getSortedKeys):
+        * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
+        (CloseBugForLandDiffTest.test_empty_state):
+        * Scripts/webkitpy/tool/steps/commit_unittest.py:
+        (CommitTest._test_check_test_expectations):
+        * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
+        (UpdateChangeLogsForRevertTest):
+
 2017-10-10  Ryosuke Niwa  <rn...@webkit.org>
 
         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner

Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -121,11 +121,11 @@
         Reverted changesets:
 
         "[Win] Build fix after r134209"
-        http://trac.webkit.org/changeset/170340
+        https://trac.webkit.org/changeset/170340
 
         "[Win] Clean up and refactor WinLauncher"
         https://bugs.webkit.org/show_bug.cgi?id=134209
-        http://trac.webkit.org/changeset/170339
+        https://trac.webkit.org/changeset/170339
 """
 
 
@@ -286,11 +286,11 @@
 Reverted changesets:
 
 "[Win] Build fix after r134209"
-http://trac.webkit.org/changeset/170340
+https://trac.webkit.org/changeset/170340
 
 "[Win] Clean up and refactor WinLauncher"
 https://bugs.webkit.org/show_bug.cgi?id=134209
-http://trac.webkit.org/changeset/170339
+https://trac.webkit.org/changeset/170339
 
 Patch by Daniel Bates <daba...@apple.com> on 2014-06-23
 """
@@ -312,11 +312,11 @@
 Reverted changesets:
 
 "[Win] Build fix after r134209"
-http://trac.webkit.org/changeset/170340
+https://trac.webkit.org/changeset/170340
 
 "[Win] Clean up and refactor WinLauncher"
 https://bugs.webkit.org/show_bug.cgi?id=134209
-http://trac.webkit.org/changeset/170339
+https://trac.webkit.org/changeset/170339
 
 Patch by Daniel Bates <daba...@apple.com> on 2014-06-23
 """

Modified: trunk/Tools/Scripts/webkitpy/common/config/committervalidator_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/common/config/committervalidator_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/common/config/committervalidator_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -36,7 +36,7 @@
     def test_flag_permission_rejection_message(self):
         validator = CommitterValidator(MockHost())
         self.assertEqual(validator._contributors_json_path(), "Tools/Scripts/webkitpy/common/config/contributors.json")
-        expected_messsage = """f...@foo.com does not have review permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
+        expected_messsage = """f...@foo.com does not have review permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
 
 - If you do not have review rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
 

Modified: trunk/Tools/Scripts/webkitpy/common/config/urls.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/common/config/urls.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/common/config/urls.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -30,11 +30,11 @@
 
 
 def view_source_url(local_path):
-    return "http://trac.webkit.org/browser/trunk/%s" % local_path
+    return "https://trac.webkit.org/browser/trunk/%s" % local_path
 
 
 def view_revision_url(revision_number):
-    return "http://trac.webkit.org/changeset/%s" % revision_number
+    return "https://trac.webkit.org/changeset/%s" % revision_number
 
 
 contribution_guidelines = "http://webkit.org/coding/contributing.html"

Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -57,18 +57,18 @@
         self.assertEqual(bug.commit_revision(), None)
 
         bug = Bug({"comments": [
-            {"text": "Committed r138776: <http://trac.webkit.org/changeset/138776>"},
+            {"text": "Committed r138776: <https://trac.webkit.org/changeset/138776>"},
             ]}, bugzilla=None)
         self.assertEqual(bug.commit_revision(), 138776)
 
         bug = Bug({"comments": [
-            {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <http://trac.webkit.org/changeset/138776>"},
+            {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <https://trac.webkit.org/changeset/138776>"},
             ]}, bugzilla=None)
         self.assertEqual(bug.commit_revision(), 138776)
 
         bug = Bug({"comments": [
             {"text": "Comment before"},
-            {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <http://trac.webkit.org/changeset/138776>"},
+            {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <https://trac.webkit.org/changeset/138776>"},
             {"text": "Comment after"},
             ]}, bugzilla=None)
         self.assertEqual(bug.commit_revision(), 138776)
@@ -75,9 +75,9 @@
 
         bug = Bug({"comments": [
             {"text": "Comment before"},
-            {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <http://trac.webkit.org/changeset/138776>"},
+            {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <https://trac.webkit.org/changeset/138776>"},
             {"text": "Comment Middle"},
-            {"text": "(From update of attachment 181280) Clearing flags on attachment: 181280 Committed r138976: <http://trac.webkit.org/changeset/138976>"},
+            {"text": "(From update of attachment 181280) Clearing flags on attachment: 181280 Committed r138976: <https://trac.webkit.org/changeset/138976>"},
             {"text": "Comment After"},
             ]}, bugzilla=None)
         self.assertEqual(bug.commit_revision(), 138976)

Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -181,7 +181,7 @@
     "bug_status": "ASSIGNED",
     "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
                   "comment_email": "b...@foo.com",
-                  "text": "Message1.\nCommitted r35: <http://trac.webkit.org/changeset/35>",
+                  "text": "Message1.\nCommitted r35: <https://trac.webkit.org/changeset/35>",
                   },
                  ],
 }
@@ -197,11 +197,11 @@
     "bug_status": "NEW",
     "comments":  [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
                    "comment_email": "b...@foo.com",
-                   "text": "Committed r30: <http://trac.webkit.org/changeset/30>",
+                   "text": "Committed r30: <https://trac.webkit.org/changeset/30>",
                    },
                   {"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
                    "comment_email": "b...@foo.com",
-                   "text": "Committed r31: <http://trac.webkit.org/changeset/31>",
+                   "text": "Committed r31: <https://trac.webkit.org/changeset/31>",
                    },
                   ],
 }
@@ -217,11 +217,11 @@
     "bug_status": "REOPENED",
     "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
                   "comment_email": "b...@foo.com",
-                  "text": "Committed r25: <http://trac.webkit.org/changeset/30>",
+                  "text": "Committed r25: <https://trac.webkit.org/changeset/30>",
                   },
                  {"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
                   "comment_email": "b...@foo.com",
-                  "text": "Rolled out in <http://trac.webkit.org/changeset/26",
+                  "text": "Rolled out in <https://trac.webkit.org/changeset/26",
                   },
                  ],
 }
@@ -238,7 +238,7 @@
     "dup_id": 50002,
     "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
                   "comment_email": "b...@foo.com",
-                  "text": "Committed r15: <http://trac.webkit.org/changeset/15>",
+                  "text": "Committed r15: <https://trac.webkit.org/changeset/15>",
                   },
                  ],
 
@@ -255,7 +255,7 @@
     "bug_status": "RESOLVED",
     "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
                   "comment_email": "b...@foo.com",
-                  "text": "Committed r95: <http://trac.webkit.org/changeset/95>",
+                  "text": "Committed r95: <https://trac.webkit.org/changeset/95>",
                   },
                  ],
 
@@ -272,7 +272,7 @@
     "bug_status": "RESOLVED",
     "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
                   "comment_email": "b...@foo.com",
-                  "text": "Message1.\nCommitted r105: <http://trac.webkit.org/changeset/105>",
+                  "text": "Message1.\nCommitted r105: <https://trac.webkit.org/changeset/105>",
                   },
                  ],
 }

Modified: trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -334,25 +334,25 @@
       </tr>
       <tr class="alt">
         <td>Jan 10 15:49</td>
-        <td><span class="revision" title="Revision 104643"><a href=""
+        <td><span class="revision" title="Revision 104643"><a href=""
         <td class="success">failure</td>    <td><a href=""
         <td class="left">Build successful</td>
       </tr>
       <tr class="">
         <td>Jan 10 15:32</td>
-        <td><span class="revision" title="Revision 104636"><a href=""
+        <td><span class="revision" title="Revision 104636"><a href=""
         <td class="success">failure</td>    <td><a href=""
         <td class="left">Build successful</td>
       </tr>
       <tr class="alt">
         <td>Jan 10 15:18</td>
-        <td><span class="revision" title="Revision 104635"><a href=""
+        <td><span class="revision" title="Revision 104635"><a href=""
         <td class="success">success</td>    <td><a href=""
         <td class="left">Build successful</td>
       </tr>
       <tr class="">
         <td>Jan 10 14:51</td>
-        <td><span class="revision" title="Revision 104633"><a href=""
+        <td><span class="revision" title="Revision 104633"><a href=""
         <td class="failure">failure</td>    <td><a href=""
         <td class="left">Failed compile-webkit</td>
       </tr>
@@ -363,27 +363,27 @@
     <table>
       <tr class="alt">
         <td>Jan 10 15:49</td>
-        <td><span class="revision" title="Revision 104643"><a href=""
+        <td><span class="revision" title="Revision 104643"><a href=""
         <td class="success">failure</td>
       </tr>
       <tr class="">
         <td>Jan 10 15:32</td>
-        <td><span class="revision" title="Revision 104636"><a href=""
+        <td><span class="revision" title="Revision 104636"><a href=""
         <td class="success">failure</td>
       </tr>
       <tr class="alt">
         <td>Jan 10 15:18</td>
-        <td><span class="revision" title="Revision 104635"><a href=""
+        <td><span class="revision" title="Revision 104635"><a href=""
         <td class="success">failure</td>
       </tr>
       <tr class="">
           <td>Jan 10 11:58</td>
-          <td><span class="revision" title="Revision ??"><a href=""
+          <td><span class="revision" title="Revision ??"><a href=""
           <td class="retry">retry</td>
         </tr>
       <tr class="">
         <td>Jan 10 14:51</td>
-        <td><span class="revision" title="Revision 104633"><a href=""
+        <td><span class="revision" title="Revision 104633"><a href=""
         <td class="failure">failure</td>
       </tr>
     </table>

Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -53,7 +53,7 @@
 
 """
 
-    results = {'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Bindings/event-target-wrapper.html',
+    results = {'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Bindings/event-target-wrapper.html',
         'metrics': {'Time': {'current': [[1486.0, 1471.0, 1510.0, 1505.0, 1478.0, 1490.0]] * 4}}}
 
 
@@ -68,7 +68,7 @@
 
 """
 
-    results = {'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/some-parser.html',
+    results = {'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/some-parser.html',
         'metrics': {'Time': {'current': [[1080.0, 1120.0, 1095.0, 1101.0, 1104.0]] * 4}}}
 
 
@@ -110,18 +110,18 @@
 Finished: 0.1 s
 """
 
-    results = {'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
+    results = {'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
         'metrics': {'Time': {'current': [[1080.0, 1120.0, 1095.0, 1101.0, 1104.0]] * 4}},
         'tests': {
             'subtest': {
-                'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
+                'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
                 'metrics': {'Time': {'current': [[1.0, 2.0, 3.0, 4.0, 5.0]] * 4}}},
             'total-test': {
-                'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
+                'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
                 'metrics': {'Time': {'current': [[1.0, 2.0, 3.0, 4.0, 5.0]] * 4, "aggregators": ["Total"]}},
                 'tests': {
                     'subsubtest':
-                        {'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
+                        {'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
                         'metrics': {'Time': {'current': [[1.0, 2.0, 3.0, 4.0, 5.0]] * 4}}}}}}}
 
 
@@ -312,10 +312,10 @@
 
     _event_target_wrapper_and_inspector_results = {
         "Bindings":
-            {"url": "http://trac.webkit.org/browser/trunk/PerformanceTests/Bindings",
+            {"url": "https://trac.webkit.org/browser/trunk/PerformanceTests/Bindings",
             "tests": {"event-target-wrapper": EventTargetWrapperTestData.results}},
         "Parser":
-            {"url": "http://trac.webkit.org/browser/trunk/PerformanceTests/Parser",
+            {"url": "https://trac.webkit.org/browser/trunk/PerformanceTests/Parser",
             "tests": {"some-parser": SomeParserTestData.results}}}
 
     def test_run_with_json_output(self):
@@ -511,10 +511,10 @@
         self.assertEqual(output['revisions'], {'WebKit': {'revision': '5678', 'timestamp': '2013-02-01 08:48:05 +0000'}})
         self.assertEqual(output['tests'].keys(), ['Bindings', 'Parser'])
         self.assertEqual(sorted(output['tests']['Bindings'].keys()), ['tests', 'url'])
-        self.assertEqual(output['tests']['Bindings']['url'], 'http://trac.webkit.org/browser/trunk/PerformanceTests/Bindings')
+        self.assertEqual(output['tests']['Bindings']['url'], 'https://trac.webkit.org/browser/trunk/PerformanceTests/Bindings')
         self.assertEqual(output['tests']['Bindings']['tests'].keys(), ['event-target-wrapper'])
         self.assertEqual(output['tests']['Bindings']['tests']['event-target-wrapper'], {
-            'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Bindings/event-target-wrapper.html',
+            'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Bindings/event-target-wrapper.html',
             'metrics': {'Time': {'current': [[1486.0, 1471.0, 1510.0, 1505.0, 1478.0, 1490.0]] * 4}}})
 
     def test_run_with_repeat(self):

Modified: trunk/Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -86,7 +86,7 @@
                           '\n'
                           '        Example bug'
                           '\n'
-                          '        http://trac.webkit.org/changeset/12345\n')
+                          '        https://trac.webkit.org/changeset/12345\n')
         self.assert_error(2, range(2, 5), 'changelog/bugnumber',
                           '2011-01-01  Patrick Gansterer  <par...@paroga.com>\n'
                           '        Example bug\n'

Modified: trunk/Tools/Scripts/webkitpy/tool/bot/feeders_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/bot/feeders_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/feeders_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -41,7 +41,7 @@
         feeder = CommitQueueFeeder(MockTool())
         expected_logs = """Warning, attachment 10001 on bug 50000 has invalid committer (non-commit...@example.com)
 Warning, attachment 10001 on bug 50000 has invalid committer (non-commit...@example.com)
-MOCK setting flag 'commit-queue' to '-' on attachment '10001' with comment 'Rejecting attachment 10001 from commit-queue.\n\nnon-commit...@example.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
+MOCK setting flag 'commit-queue' to '-' on attachment '10001' with comment 'Rejecting attachment 10001 from commit-queue.\n\nnon-commit...@example.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
 
 - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
 

Modified: trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -76,7 +76,7 @@
 foo/bar.html has been flaky on the dummy-queue.
 
 foo/bar.html was authored by t...@test.com.
-http://trac.webkit.org/browser/trunk/LayoutTests/foo/bar.html
+https://trac.webkit.org/browser/trunk/LayoutTests/foo/bar.html
 
 FLAKE_MESSAGE
 
@@ -112,7 +112,7 @@
 foo/bar.html has been flaky on the dummy-queue.
 
 foo/bar.html was authored by aba...@webkit.org.
-http://trac.webkit.org/browser/trunk/LayoutTests/foo/bar.html
+https://trac.webkit.org/browser/trunk/LayoutTests/foo/bar.html
 
 The dummy-queue just saw foo/bar.html flake (text diff) while processing attachment 10000 on bug 50000.
 Bot: mock-bot-id  Port: MockPort  Platform: MockPlatform 1.0

Modified: trunk/Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -95,23 +95,23 @@
         OutputCapture().assert_outputs(self, run, args=["restart"], expected_logs=expected_logs, expected_exception=TerminateQueue)
 
     def test_rollout(self):
-        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
+        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
         OutputCapture().assert_outputs(self, run, args=["rollout 21654 This patch broke the world"], expected_logs=expected_logs)
 
     def test_revert(self):
-        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
+        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
         OutputCapture().assert_outputs(self, run, args=["revert 21654 This patch broke the world"], expected_logs=expected_logs)
 
     def test_multi_rollout(self):
-        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654, http://trac.webkit.org/changeset/21655, and http://trac.webkit.org/changeset/21656 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
+        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654, https://trac.webkit.org/changeset/21655, and https://trac.webkit.org/changeset/21656 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
         OutputCapture().assert_outputs(self, run, args=["rollout 21654 21655 21656 This 21654 patch broke the world"], expected_logs=expected_logs)
 
     def test_rollout_with_r_in_svn_revision(self):
-        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
+        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
         OutputCapture().assert_outputs(self, run, args=["rollout r21654 This patch broke the world"], expected_logs=expected_logs)
 
     def test_multi_rollout_with_r_in_svn_revision(self):
-        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654, http://trac.webkit.org/changeset/21655, and http://trac.webkit.org/changeset/21656 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
+        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654, https://trac.webkit.org/changeset/21655, and https://trac.webkit.org/changeset/21656 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
         OutputCapture().assert_outputs(self, run, args=["rollout r21654 21655 r21656 This r21654 patch broke the world"], expected_logs=expected_logs)
 
     def test_rollout_bananas(self):
@@ -127,7 +127,7 @@
 
     def test_rollout_invalidate_reason(self):
         # FIXME: I'm slightly confused as to why this doesn't return the USAGE message.
-        expected_logs = """MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654 ...
+        expected_logs = """MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654 ...
 MOCK: irc.post: mock_nick, abarth, darin, eseidel: Failed to create rollout patch:
 MOCK: irc.post: The rollout reason may not begin with - (\"-bad (Requested by mock_nick on #webkit).\").
 """
@@ -136,7 +136,7 @@
                                        expected_logs=expected_logs)
 
     def test_multi_rollout_invalidate_reason(self):
-        expected_logs = """MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654, http://trac.webkit.org/changeset/21655, and http://trac.webkit.org/changeset/21656 ...
+        expected_logs = """MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654, https://trac.webkit.org/changeset/21655, and https://trac.webkit.org/changeset/21656 ...
 MOCK: irc.post: mock_nick, abarth, darin, eseidel: Failed to create rollout patch:
 MOCK: irc.post: The rollout reason may not begin with - (\"-bad (Requested by mock_nick on #webkit).\").
 """

Modified: trunk/Tools/Scripts/webkitpy/tool/bot/sheriff_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/bot/sheriff_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/sheriff_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -67,12 +67,12 @@
 
         expected_logs = u"""MOCK bug comment: bug_id=1234, cc=['watc...@example.com']
 --- Begin comment ---
-http://trac.webkit.org/changeset/4321 might have broken Foo and Bar
+https://trac.webkit.org/changeset/4321 might have broken Foo and Bar
 --- End comment ---
 
 MOCK bug comment: bug_id=1234, cc=['watc...@example.com']
 --- Begin comment ---
-http://trac.webkit.org/changeset/4321 might have broken Foo and Bar
+https://trac.webkit.org/changeset/4321 might have broken Foo and Bar
 The following tests are not passing:
 mock-test-1
 --- End comment ---
@@ -79,7 +79,7 @@
 
 MOCK bug comment: bug_id=1234, cc=['watc...@example.com']
 --- Begin comment ---
-http://trac.webkit.org/changeset/4321 might have broken Foo and Bar
+https://trac.webkit.org/changeset/4321 might have broken Foo and Bar
 The following tests are not passing:
 mock-test-1
 mock-test-2

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -146,7 +146,7 @@
 Running _javascript_Core tests
 Running bindings generation tests
 Running run-webkit-tests
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 Updating bug 50000
 """
         mock_tool = MockTool()
@@ -175,8 +175,8 @@
 MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
 Running run-webkit-tests
 MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--quiet'], cwd=/mock-checkout
-Committed r49824: <http://trac.webkit.org/changeset/49824>
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 No bug id provided.
 """
         mock_tool = MockTool(log_executive=True)
@@ -192,7 +192,7 @@
 Running _javascript_Core tests
 Running bindings generation tests
 Running run-webkit-tests
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 Updating bug 50000
 """
         mock_tool = MockTool()
@@ -223,7 +223,7 @@
 Running _javascript_Core tests
 Running bindings generation tests
 Running run-webkit-tests
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
 """
         self.assert_execute_outputs(LandAttachment(), [10000], options=self._default_options(), expected_logs=expected_logs)
@@ -240,7 +240,7 @@
 Running _javascript_Core tests
 Running bindings generation tests
 Running run-webkit-tests
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
 Updating working directory
 Processing patch 10001 from bug 50000.
@@ -250,7 +250,7 @@
 Running _javascript_Core tests
 Running bindings generation tests
 Running run-webkit-tests
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
 """
         self.assert_execute_outputs(LandFromBug(), [50000], options=self._default_options(), expected_logs=expected_logs)
@@ -267,7 +267,7 @@
 Running _javascript_Core tests
 Running bindings generation tests
 Running run-webkit-tests
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
 Updating working directory
 Processing patch 10001 from bug 50000.
@@ -277,7 +277,7 @@
 Running _javascript_Core tests
 Running bindings generation tests
 Running run-webkit-tests
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
 """
         self.assert_execute_outputs(LandFromURL(), ["https://bugs.webkit.org/show_bug.cgi?id=50000"], options=self._default_options(), expected_logs=expected_logs)
@@ -291,7 +291,7 @@
 Updating working directory
 MOCK create_bug
 bug_title: REGRESSION(r852): Reason
-bug_description: http://trac.webkit.org/changeset/852 broke the build:
+bug_description: https://trac.webkit.org/changeset/852 broke the build:
 Reason
 component: MOCK component
 cc: MOCK cc
@@ -316,7 +316,7 @@
 Updating working directory
 MOCK create_bug
 bug_title: REGRESSION(r852): Reason
-bug_description: http://trac.webkit.org/changeset/852 broke the build:
+bug_description: https://trac.webkit.org/changeset/852 broke the build:
 Reason
 component: MOCK component
 cc: MOCK cc
@@ -341,7 +341,7 @@
 Updating working directory
 MOCK create_bug
 bug_title: REGRESSION(r852): Reason
-bug_description: http://trac.webkit.org/changeset/852 broke the build:
+bug_description: https://trac.webkit.org/changeset/852 broke the build:
 Reason
 component: MOCK component
 cc: MOCK cc
@@ -365,7 +365,7 @@
 Updating working directory
 MOCK create_bug
 bug_title: REGRESSION(r3001): Reason
-bug_description: http://trac.webkit.org/changeset/3001 broke the build:
+bug_description: https://trac.webkit.org/changeset/3001 broke the build:
 Reason
 component: MOCK component
 cc: MOCK cc
@@ -391,7 +391,7 @@
 Updating working directory
 MOCK create_bug
 bug_title: REGRESSION(r963): Reason
-bug_description: http://trac.webkit.org/changeset/963 broke the build:
+bug_description: https://trac.webkit.org/changeset/963 broke the build:
 Reason
 component: MOCK component
 cc: MOCK cc
@@ -418,12 +418,12 @@
 MOCK: user.open_url: file://...
 Was that diff correct?
 Building WebKit
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 MOCK reopen_bug 50000 with comment 'Reverted r852 for reason:
 
 Reason
 
-Committed r49824: <http://trac.webkit.org/changeset/49824>'
+Committed r49824: <https://trac.webkit.org/changeset/49824>'
 """
         self.assert_execute_outputs(Rollout(), [852, "Reason", "Description"], options=self._default_options(), expected_logs=expected_logs)
 
@@ -434,17 +434,17 @@
 MOCK: user.open_url: file://...
 Was that diff correct?
 Building WebKit
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 MOCK reopen_bug 50000 with comment 'Reverted r852 and r963 for reason:
 
 Reason
 
-Committed r49824: <http://trac.webkit.org/changeset/49824>'
+Committed r49824: <https://trac.webkit.org/changeset/49824>'
 MOCK reopen_bug 50005 with comment 'Reverted r852 and r963 for reason:
 
 Reason
 
-Committed r49824: <http://trac.webkit.org/changeset/49824>'
+Committed r49824: <https://trac.webkit.org/changeset/49824>'
 """
         self.assert_execute_outputs(Rollout(), ["852 963", "Reason", "Description"], options=self._default_options(), expected_logs=expected_logs)
 
@@ -456,22 +456,22 @@
 MOCK: user.open_url: file://...
 Was that diff correct?
 Building WebKit
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 MOCK reopen_bug 50000 with comment 'Reverted r852, r963, and r3001 for reason:
 
 Reason
 
-Committed r49824: <http://trac.webkit.org/changeset/49824>'
+Committed r49824: <https://trac.webkit.org/changeset/49824>'
 MOCK reopen_bug 50005 with comment 'Reverted r852, r963, and r3001 for reason:
 
 Reason
 
-Committed r49824: <http://trac.webkit.org/changeset/49824>'
+Committed r49824: <https://trac.webkit.org/changeset/49824>'
 MOCK reopen_bug 50004 with comment 'Reverted r852, r963, and r3001 for reason:
 
 Reason
 
-Committed r49824: <http://trac.webkit.org/changeset/49824>'
+Committed r49824: <https://trac.webkit.org/changeset/49824>'
 """
         self.assert_execute_outputs(Rollout(), ["852 3001 963", "Reason", "Description"], options=self._default_options(), expected_logs=expected_logs)
 
@@ -483,16 +483,16 @@
 MOCK: user.open_url: file://...
 Was that diff correct?
 Building WebKit
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 MOCK reopen_bug 50000 with comment 'Reverted r852, r963, and r999 for reason:
 
 Reason
 
-Committed r49824: <http://trac.webkit.org/changeset/49824>'
+Committed r49824: <https://trac.webkit.org/changeset/49824>'
 MOCK reopen_bug 50005 with comment 'Reverted r852, r963, and r999 for reason:
 
 Reason
 
-Committed r49824: <http://trac.webkit.org/changeset/49824>'
+Committed r49824: <https://trac.webkit.org/changeset/49824>'
 """
         self.assert_execute_outputs(Rollout(), ["852 999 963", "Reason", "Description"], options=self._default_options(), expected_logs=expected_logs)

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -88,7 +88,7 @@
 r143104 | commit-qu...@webkit.org | 2013-02-16 09:09:01 -0800 (Sat, 16 Feb 2013) | 27 lines
 
 Unreviewed, rolling out r142734.
-http://trac.webkit.org/changeset/142734
+https://trac.webkit.org/changeset/142734
 https://bugs.webkit.org/show_bug.cgi?id=110018
 
 "Triggered crashes on lots of websites" (Requested by ggaren
@@ -124,8 +124,8 @@
 r135487 | commit-qu...@webkit.org | 2012-11-22 00:09:25 -0800 (Thu, 22 Nov 2012) | 52 lines
 
 Unreviewed, rolling out r134927 and r134944.
-http://trac.webkit.org/changeset/134927
-http://trac.webkit.org/changeset/134944
+https://trac.webkit.org/changeset/134927
+https://trac.webkit.org/changeset/134944
 https://bugs.webkit.org/show_bug.cgi?id=103028
 
 Reverting the reverts after merging. (Requested by vsevik on

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -136,7 +136,7 @@
             "begin_work_queue": self._default_begin_work_queue_logs("feeder-queue"),
             "process_work_item": """Warning, attachment 10001 on bug 50000 has invalid committer (non-commit...@example.com)
 Warning, attachment 10001 on bug 50000 has invalid committer (non-commit...@example.com)
-MOCK setting flag 'commit-queue' to '-' on attachment '10001' with comment 'Rejecting attachment 10001 from commit-queue.\n\nnon-commit...@example.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
+MOCK setting flag 'commit-queue' to '-' on attachment '10001' with comment 'Rejecting attachment 10001 from commit-queue.\n\nnon-commit...@example.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
 
 - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
 

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -202,7 +202,7 @@
         counter['count'] = counter.get('count', 0) + 1
 
         if revision.isdigit():
-            revision = "http://trac.webkit.org/changeset/" + revision
+            revision = "https://trac.webkit.org/changeset/" + revision
         counter['commits'] += "  commit: %s on %s by %s (%s)\n" % (revision, commit_date, author_name, author_email)
 
     def _count_recent_patches(self):

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -173,7 +173,7 @@
 --- Begin comment ---
 MOCK comment
 
-Committed r9876: <http://trac.webkit.org/changeset/9876>
+Committed r9876: <https://trac.webkit.org/changeset/9876>
 --- End comment ---
 
 """

Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js	2017-10-11 13:59:44 UTC (rev 223177)
@@ -90,7 +90,7 @@
 
 function getTracUrl(layoutTestPath)
 {
-  return 'http://trac.webkit.org/browser/trunk/LayoutTests/' + layoutTestPath;
+  return 'https://trac.webkit.org/browser/trunk/LayoutTests/' + layoutTestPath;
 }
 
 function getSortedKeys(obj)
@@ -101,4 +101,4 @@
     }
     keys.sort();
     return keys;
-}
\ No newline at end of file
+}

Modified: trunk/Tools/Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -37,5 +37,5 @@
     def test_empty_state(self):
         capture = OutputCapture()
         step = CloseBugForLandDiff(MockTool(), MockOptions())
-        expected_logs = "Committed r49824: <http://trac.webkit.org/changeset/49824>\nNo bug id provided.\n"
+        expected_logs = "Committed r49824: <https://trac.webkit.org/changeset/49824>\nNo bug id provided.\n"
         capture.assert_outputs(self, step.run, [{"commit_text": "Mock commit text"}], expected_logs=expected_logs)

Modified: trunk/Tools/Scripts/webkitpy/tool/steps/commit_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/steps/commit_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/commit_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -50,7 +50,7 @@
         }
 
         tool.executive = MockExecutive(should_log=True, should_throw_when_run=False)
-        expected_logs = "Committed r49824: <http://trac.webkit.org/changeset/49824>\n"
+        expected_logs = "Committed r49824: <https://trac.webkit.org/changeset/49824>\n"
         capture.assert_outputs(self, step.run, [state], expected_logs=expected_logs)
 
         state = {
@@ -57,7 +57,7 @@
             "changed_files": ["platform/chromium/" + filename],
         }
         expected_logs = """MOCK run_and_throw_if_fail: ['mock-check-webkit-style', '--diff-files', 'platform/chromium/%s'], cwd=/mock-checkout
-Committed r49824: <http://trac.webkit.org/changeset/49824>
+Committed r49824: <https://trac.webkit.org/changeset/49824>
 """ % filename
         capture.assert_outputs(self, step.run, [state], expected_logs=expected_logs)
 

Modified: trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py (223176 => 223177)


--- trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py	2017-10-11 13:51:58 UTC (rev 223176)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py	2017-10-11 13:59:44 UTC (rev 223177)
@@ -47,7 +47,7 @@
 
         "Blocked Bug's Description"
         http://bug.example.com/12345
-        http://trac.webkit.org/changeset/12345
+        https://trac.webkit.org/changeset/12345
 '''
 
     _revert_entry_with_missing_bug_url_and_description = '''2009-08-19  Eric Seidel  <e...@webkit.org>
@@ -58,7 +58,7 @@
 
         Reverted changeset:
 
-        http://trac.webkit.org/changeset/12345
+        https://trac.webkit.org/changeset/12345
 '''
 
     _multiple_revert_entry = '''2009-08-19  Eric Seidel  <e...@webkit.org>
@@ -71,15 +71,15 @@
 
         "r12345's Description"
         http://bug.example.com/12345
-        http://trac.webkit.org/changeset/12345
+        https://trac.webkit.org/changeset/12345
 
         "r12346's Description"
         http://bug.example.com/12346
-        http://trac.webkit.org/changeset/12346
+        https://trac.webkit.org/changeset/12346
 
         "r12347's Description"
         http://bug.example.com/12347
-        http://trac.webkit.org/changeset/12347
+        https://trac.webkit.org/changeset/12347
 '''
 
     _multiple_revert_entry_with_missing_bug_urls_and_descriptions = '''2009-08-19  Eric Seidel  <e...@webkit.org>
@@ -90,11 +90,11 @@
 
         Reverted changesets:
 
-        http://trac.webkit.org/changeset/12345
+        https://trac.webkit.org/changeset/12345
 
-        http://trac.webkit.org/changeset/12346
+        https://trac.webkit.org/changeset/12346
 
-        http://trac.webkit.org/changeset/12347
+        https://trac.webkit.org/changeset/12347
 '''
 
     _multiple_revert_entry_with_a_missing_bug_url_and_description = '''2009-08-19  Eric Seidel  <e...@webkit.org>
@@ -107,13 +107,13 @@
 
         "r12345's Description"
         http://bug.example.com/12345
-        http://trac.webkit.org/changeset/12345
+        https://trac.webkit.org/changeset/12345
 
-        http://trac.webkit.org/changeset/12346
+        https://trac.webkit.org/changeset/12346
 
         "r12347's Description"
         http://bug.example.com/12347
-        http://trac.webkit.org/changeset/12347
+        https://trac.webkit.org/changeset/12347
 '''
 
     _revert_with_long_reason = """2009-08-19  Eric Seidel  <e...@webkit.org>
@@ -130,7 +130,7 @@
 
         "Blocked Bug's Description"
         http://bug.example.com/12345
-        http://trac.webkit.org/changeset/12345
+        https://trac.webkit.org/changeset/12345
 """
 
     _multiple_revert_entry_with_rollout_bug_url = '''2009-08-19  Eric Seidel  <e...@webkit.org>
@@ -144,15 +144,15 @@
 
         "r12345's Description"
         http://bug.example.com/12345
-        http://trac.webkit.org/changeset/12345
+        https://trac.webkit.org/changeset/12345
 
         "r12346's Description"
         http://bug.example.com/12346
-        http://trac.webkit.org/changeset/12346
+        https://trac.webkit.org/changeset/12346
 
         "r12347's Description"
         http://bug.example.com/12347
-        http://trac.webkit.org/changeset/12347
+        https://trac.webkit.org/changeset/12347
 '''
 
     def _assert_message_for_revert_output(self, args, expected_entry):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to