Title: [223454] trunk/Tools
- Revision
- 223454
- Author
- commit-qu...@webkit.org
- Date
- 2017-10-16 19:30:58 -0700 (Mon, 16 Oct 2017)
Log Message
[Win] Webkit should still be able to build when unable to check if libraries are up to date
https://bugs.webkit.org/show_bug.cgi?id=178367
Adding a option to skip the check to see if windows libraries are up to date.
This option is useful when testing modified libraries. This option also allows
building webkit when GitHub blocks requests to verify the latest library version.
Patch by Christopher Reid <chris.r...@sony.com> on 2017-10-16
Reviewed by Per Arne Vollan.
* Scripts/build-webkit:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (223453 => 223454)
--- trunk/Tools/ChangeLog 2017-10-17 02:25:15 UTC (rev 223453)
+++ trunk/Tools/ChangeLog 2017-10-17 02:30:58 UTC (rev 223454)
@@ -1,3 +1,17 @@
+2017-10-16 Christopher Reid <chris.r...@sony.com>
+
+ [Win] Webkit should still be able to build when unable to check if libraries are up to date
+ https://bugs.webkit.org/show_bug.cgi?id=178367
+
+ Adding a option to skip the check to see if windows libraries are up to date.
+ This option is useful when testing modified libraries. This option also allows
+ building webkit when GitHub blocks requests to verify the latest library version.
+
+
+ Reviewed by Per Arne Vollan.
+
+ * Scripts/build-webkit:
+
2017-10-12 Matt Rajca <mra...@apple.com>
Add API support for quirk that lets an arbitrary click allow auto-play.
Modified: trunk/Tools/Scripts/build-webkit (223453 => 223454)
--- trunk/Tools/Scripts/build-webkit 2017-10-17 02:25:15 UTC (rev 223453)
+++ trunk/Tools/Scripts/build-webkit 2017-10-17 02:30:58 UTC (rev 223454)
@@ -65,6 +65,7 @@
my $shouldRunStaticAnalyzer = 0;
my $startTime = time();
my $archs32bit = 0;
+my $skipLibraryUpdate = 0;
my @features = getFeatureOptionList();
@@ -117,6 +118,8 @@
--only-webkit Build only the WebKit project
+ --skip-library-update Skip the check to see if windows libraries are up to date
+
EOF
my %options = (
@@ -133,6 +136,7 @@
'coverage' => \$coverageSupport,
'analyze' => \$shouldRunStaticAnalyzer,
'default-cmake-features' => \$defaultCMakeFeatures,
+ 'skip-library-update' => \$skipLibraryUpdate
);
# Build usage text and options list from features
@@ -223,9 +227,9 @@
# Build Tools needed for Apple ports
push @projects, ("Tools/DumpRenderTree", "Tools/WebKitTestRunner", "Source/ThirdParty/gtest", "Tools/TestWebKitAPI");
-} elsif (isWinCairo()) {
+} elsif (isWinCairo() && !$skipLibraryUpdate) {
(system("python Tools/Scripts/update-webkit-wincairo-libs.py") == 0) or die;
-} elsif (isAppleWinWebKit()) {
+} elsif (isAppleWinWebKit() && !$skipLibraryUpdate) {
# Copy WebKitSupportLibrary to the correct location in WebKitLibraries so it can be found.
# Will fail if WebKitSupportLibrary.zip is not in source root.
(system("perl Tools/Scripts/update-webkit-support-libs") == 0) or die;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
