Diff
Modified: trunk/Tools/ChangeLog (223795 => 223796)
--- trunk/Tools/ChangeLog 2017-10-20 21:20:08 UTC (rev 223795)
+++ trunk/Tools/ChangeLog 2017-10-20 21:56:51 UTC (rev 223796)
@@ -1,3 +1,20 @@
+2017-10-20 Aakash Jain <aakash_j...@apple.com>
+
+ Do not run binding tests on multiple EWSes
+ https://bugs.webkit.org/show_bug.cgi?id=178599
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove old code which runs bindings tests and ignore it's result. We now have
+ a dedicated bindings test EWS.
+
+ * Scripts/webkitpy/tool/steps/runtests.py:
+ (RunTests.run): Removed bindings tests code.
+ * Scripts/webkitpy/tool/steps/runtests_unittest.py: Updated unit-tests.
+ (RunTestsTest.test_webkit_run_unit_tests): Ditto.
+ * Scripts/webkitpy/tool/steps/steps_unittest.py: Ditto.
+ * Scripts/webkitpy/tool/commands/download_unittest.py: Ditto.
+
2017-10-20 Youenn Fablet <you...@apple.com>
WebsiteDataStoreCustomPaths.mm is failing after r223718
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (223795 => 223796)
--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2017-10-20 21:20:08 UTC (rev 223795)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2017-10-20 21:56:51 UTC (rev 223796)
@@ -103,7 +103,6 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
-Running bindings generation tests
Running run-webkit-tests
"""
self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_logs=expected_logs)
@@ -144,7 +143,6 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
-Running bindings generation tests
Running run-webkit-tests
Committed r49824: <https://trac.webkit.org/changeset/49824>
Updating bug 50000
@@ -171,8 +169,6 @@
MOCK run_and_throw_if_fail: ['mock-test-webkitperl'], cwd=/mock-checkout
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['mock-run-javacriptcore-tests'], cwd=/mock-checkout
-Running bindings generation tests
-MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
Running run-webkit-tests
MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--quiet'], cwd=/mock-checkout
Committed r49824: <https://trac.webkit.org/changeset/49824>
@@ -190,7 +186,6 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
-Running bindings generation tests
Running run-webkit-tests
Committed r49824: <https://trac.webkit.org/changeset/49824>
Updating bug 50000
@@ -221,7 +216,6 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
-Running bindings generation tests
Running run-webkit-tests
Committed r49824: <https://trac.webkit.org/changeset/49824>
Not closing bug 50000 as attachment 10000 has review=+. Assuming there are more patches to land from this bug.
@@ -238,7 +232,6 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
-Running bindings generation tests
Running run-webkit-tests
Committed r49824: <https://trac.webkit.org/changeset/49824>
Not closing bug 50000 as attachment 10000 has review=+. Assuming there are more patches to land from this bug.
@@ -248,7 +241,6 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
-Running bindings generation tests
Running run-webkit-tests
Committed r49824: <https://trac.webkit.org/changeset/49824>
Not closing bug 50000 as attachment 10000 has review=+. Assuming there are more patches to land from this bug.
@@ -265,7 +257,6 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
-Running bindings generation tests
Running run-webkit-tests
Committed r49824: <https://trac.webkit.org/changeset/49824>
Not closing bug 50000 as attachment 10000 has review=+. Assuming there are more patches to land from this bug.
@@ -275,7 +266,6 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
-Running bindings generation tests
Running run-webkit-tests
Committed r49824: <https://trac.webkit.org/changeset/49824>
Not closing bug 50000 as attachment 10000 has review=+. Assuming there are more patches to land from this bug.
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (223795 => 223796)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2017-10-20 21:20:08 UTC (rev 223795)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2017-10-20 21:56:51 UTC (rev 223796)
@@ -104,15 +104,6 @@
_log.info("Running _javascript_Core tests")
self._tool.executive.run_and_throw_if_fail(_javascript_core_tests_command, quiet=True, cwd=self._tool.scm().checkout_root)
- bindings_tests_command = self._tool.deprecated_port().run_bindings_tests_command()
- if bindings_tests_command:
- _log.info("Running bindings generation tests")
- args = bindings_tests_command
- try:
- self._tool.executive.run_and_throw_if_fail(args, cwd=self._tool.scm().checkout_root)
- except ScriptError, e:
- _log.info("Error running run-bindings-tests: %s" % e.message_with_output())
-
_log.info("Running run-webkit-tests")
self._run_webkit_tests()
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py (223795 => 223796)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py 2017-10-20 21:20:08 UTC (rev 223795)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py 2017-10-20 21:56:51 UTC (rev 223796)
@@ -43,15 +43,11 @@
step = RunTests(tool, MockOptions(test=True, non_interactive=True, quiet=False, build_style="release", iterate_on_new_tests=0, group=None))
if sys.platform != "cygwin":
- expected_logs = """Running bindings generation tests
-MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
-Running run-webkit-tests
+ expected_logs = """Running run-webkit-tests
MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet', '--skip-failing-tests'], cwd=/mock-checkout
"""
else:
- expected_logs = """Running bindings generation tests
-MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
-Running run-webkit-tests
+ expected_logs = """Running run-webkit-tests
MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--no-build'], cwd=/mock-checkout
"""
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py (223795 => 223796)
--- trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2017-10-20 21:20:08 UTC (rev 223795)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2017-10-20 21:56:51 UTC (rev 223796)
@@ -124,8 +124,6 @@
MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl'], cwd=/mock-checkout
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/run-_javascript_core-tests', '--no-fail-fast'], cwd=/mock-checkout
-Running bindings generation tests
-MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests'], cwd=/mock-checkout
Running run-webkit-tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/run-webkit-tests', '--release', '--quiet'], cwd=/mock-checkout
"""
@@ -146,8 +144,6 @@
MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl'], cwd=/mock-checkout
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/run-_javascript_core-tests', '--no-fail-fast'], cwd=/mock-checkout
-Running bindings generation tests
-MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests'], cwd=/mock-checkout
Running run-webkit-tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/run-webkit-tests', '--debug', '--quiet'], cwd=/mock-checkout
"""
