Title: [223798] trunk/Source/WebKit
Revision
223798
Author
achristen...@apple.com
Date
2017-10-20 16:12:10 -0700 (Fri, 20 Oct 2017)

Log Message

Fix download tests on El Capitan after r223730
https://bugs.webkit.org/show_bug.cgi?id=178547

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Revert to original behavior.  This uses suggestedFilename, which may have come from places like
the download attribute, instead of always using the filename from CFNetwork.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (223797 => 223798)


--- trunk/Source/WebKit/ChangeLog	2017-10-20 23:09:10 UTC (rev 223797)
+++ trunk/Source/WebKit/ChangeLog	2017-10-20 23:12:10 UTC (rev 223798)
@@ -1,5 +1,15 @@
 2017-10-20  Alex Christensen  <achristen...@webkit.org>
 
+        Fix download tests on El Capitan after r223730
+        https://bugs.webkit.org/show_bug.cgi?id=178547
+
+        * UIProcess/Downloads/DownloadProxy.cpp:
+        (WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
+        Revert to original behavior.  This uses suggestedFilename, which may have come from places like
+        the download attribute, instead of always using the filename from CFNetwork.
+
+2017-10-20  Alex Christensen  <achristen...@webkit.org>
+
         Expose _boundInterfaceIdentifier and _allowsCellularAccess to WKWebsiteDataStorePrivate
         https://bugs.webkit.org/show_bug.cgi?id=178418
         <rdar://problem/29599569>

Modified: trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp (223797 => 223798)


--- trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp	2017-10-20 23:09:10 UTC (rev 223797)
+++ trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp	2017-10-20 23:12:10 UTC (rev 223798)
@@ -205,7 +205,7 @@
         return;
 
     String suggestedFilename = MIMETypeRegistry::appendFileExtensionIfNecessary(m_suggestedFilename.isEmpty() ? filename : m_suggestedFilename, mimeType);
-    m_processPool->downloadClient().decideDestinationWithSuggestedFilename(*m_processPool, *this, filename, [reply = WTFMove(reply)] (AllowOverwrite allowOverwrite, String destination) {
+    m_processPool->downloadClient().decideDestinationWithSuggestedFilename(*m_processPool, *this, suggestedFilename, [reply = WTFMove(reply)] (AllowOverwrite allowOverwrite, String destination) {
         SandboxExtension::Handle sandboxExtensionHandle;
         if (!destination.isNull())
             SandboxExtension::createHandle(destination, SandboxExtension::Type::ReadWrite, sandboxExtensionHandle);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to