Title: [223808] trunk/Source/WebKit
Revision
223808
Author
achristen...@apple.com
Date
2017-10-20 23:16:54 -0700 (Fri, 20 Oct 2017)

Log Message

Add FIXME comment after r223803
https://bugs.webkit.org/show_bug.cgi?id=178418

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
We need some work to better support customized persistent data stores.  Add a comment indicating such.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (223807 => 223808)


--- trunk/Source/WebKit/ChangeLog	2017-10-21 05:04:28 UTC (rev 223807)
+++ trunk/Source/WebKit/ChangeLog	2017-10-21 06:16:54 UTC (rev 223808)
@@ -1,5 +1,14 @@
 2017-10-20  Alex Christensen  <achristen...@webkit.org>
 
+        Add FIXME comment after r223803
+        https://bugs.webkit.org/show_bug.cgi?id=178418
+
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::ensureNetworkProcess):
+        We need some work to better support customized persistent data stores.  Add a comment indicating such.
+
+2017-10-20  Alex Christensen  <achristen...@webkit.org>
+
         Fix API tests after r223791.
         https://bugs.webkit.org/show_bug.cgi?id=178418
 

Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (223807 => 223808)


--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2017-10-21 05:04:28 UTC (rev 223807)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2017-10-21 06:16:54 UTC (rev 223808)
@@ -427,6 +427,9 @@
     if (withWebsiteDataStore) {
         auto websiteDataStoreParameters = withWebsiteDataStore->parameters();
         parameters.defaultSessionParameters = websiteDataStoreParameters.networkSessionParameters;
+
+        // FIXME: This isn't conceptually correct, but it's needed to preserve behavior introduced in r213241.
+        // We should separate the concept of the default session from the currently used persistent session.
         parameters.defaultSessionParameters.sessionID = PAL::SessionID::defaultSessionID();
     }
     
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to