Title: [223867] trunk/Source/WebInspectorUI
Revision
223867
Author
nvasil...@apple.com
Date
2017-10-23 17:35:42 -0700 (Mon, 23 Oct 2017)

Log Message

Web Inspector: Styles Redesign: Inline widgets don't hide when starting editing by tabbing from property name
https://bugs.webkit.org/show_bug.cgi?id=178638

Reviewed by Joseph Pecoraro.

* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
Blur event on the property name text field caused WI.SpreadsheetStyleProperty.prototype._renderValue,
which displayed inline swatches. Display inline swatches only after blur event on the property value.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (223866 => 223867)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-10-24 00:29:40 UTC (rev 223866)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-10-24 00:35:42 UTC (rev 223867)
@@ -1,3 +1,15 @@
+2017-10-23  Nikita Vasilyev  <nvasil...@apple.com>
+
+        Web Inspector: Styles Redesign: Inline widgets don't hide when starting editing by tabbing from property name
+        https://bugs.webkit.org/show_bug.cgi?id=178638
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/SpreadsheetStyleProperty.js:
+        (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
+        Blur event on the property name text field caused WI.SpreadsheetStyleProperty.prototype._renderValue,
+        which displayed inline swatches. Display inline swatches only after blur event on the property value.
+
 2017-10-23  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Please support HAR Export for network traffic

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (223866 => 223867)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2017-10-24 00:29:40 UTC (rev 223866)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2017-10-24 00:35:42 UTC (rev 223867)
@@ -235,7 +235,7 @@
     {
         if (textField.value.trim() === "")
             this._remove();
-        else
+        else if (textField === this._valueTextField)
             this._renderValue(this._valueElement.textContent);
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to