Title: [223927] trunk/Source/WebInspectorUI
- Revision
- 223927
- Author
- commit-qu...@webkit.org
- Date
- 2017-10-24 14:55:36 -0700 (Tue, 24 Oct 2017)
Log Message
Uncaught Exception: TypeError: null is not an object (evaluating 'this.treeOutline.isXMLMimeType')
https://bugs.webkit.org/show_bug.cgi?id=178745
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-10-24
Reviewed by Brian Burg.
* UserInterface/Views/DOMTreeUpdater.js:
(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
An earlier tree element update might have caused this other tree element's
waiting to be updated to actually be removed. So just skip past them.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (223926 => 223927)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-24 21:48:10 UTC (rev 223926)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-24 21:55:36 UTC (rev 223927)
@@ -1,3 +1,15 @@
+2017-10-24 Joseph Pecoraro <pecor...@apple.com>
+
+ Uncaught Exception: TypeError: null is not an object (evaluating 'this.treeOutline.isXMLMimeType')
+ https://bugs.webkit.org/show_bug.cgi?id=178745
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/DOMTreeUpdater.js:
+ (WI.DOMTreeUpdater.prototype._updateModifiedNodes):
+ An earlier tree element update might have caused this other tree element's
+ waiting to be updated to actually be removed. So just skip past them.
+
2017-10-24 Fujii Hironori <hironori.fu...@sony.com>
[GTK] Web Inspector: Add Recording.svg
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js (223926 => 223927)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js 2017-10-24 21:48:10 UTC (rev 223926)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js 2017-10-24 21:55:36 UTC (rev 223927)
@@ -120,8 +120,10 @@
this._recentlyDeletedNodes.forEach(markNodeParentForUpdate);
for (let parentTreeElement of parentElementsToUpdate) {
- parentTreeElement.updateTitle();
- parentTreeElement.updateChildren();
+ if (parentTreeElement.treeOutline) {
+ parentTreeElement.updateTitle();
+ parentTreeElement.updateChildren();
+ }
}
for (let node of this._recentlyModifiedNodes.values()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
