Title: [223938] trunk/LayoutTests
Revision
223938
Author
dba...@webkit.org
Date
2017-10-24 16:33:03 -0700 (Tue, 24 Oct 2017)

Log Message

Test fast/writing-mode/english-bt-text-with-spelling-marker.html should wait for editing commands to complete
https://bugs.webkit.org/show_bug.cgi?id=178759

Reviewed by Ryosuke Niwa.

Make use of typeCharacterCommand() from (LayoutTests/editing/editing.js) to type each character
with a delay and delay test completion until all characters have been typed.

* fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
* fast/writing-mode/english-bt-text-with-spelling-marker.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (223937 => 223938)


--- trunk/LayoutTests/ChangeLog	2017-10-24 22:59:51 UTC (rev 223937)
+++ trunk/LayoutTests/ChangeLog	2017-10-24 23:33:03 UTC (rev 223938)
@@ -1,3 +1,16 @@
+2017-10-24  Daniel Bates  <daba...@apple.com>
+
+        Test fast/writing-mode/english-bt-text-with-spelling-marker.html should wait for editing commands to complete
+        https://bugs.webkit.org/show_bug.cgi?id=178759
+
+        Reviewed by Ryosuke Niwa.
+
+        Make use of typeCharacterCommand() from (LayoutTests/editing/editing.js) to type each character
+        with a delay and delay test completion until all characters have been typed.
+
+        * fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
+        * fast/writing-mode/english-bt-text-with-spelling-marker.html:
+
 2017-10-24  Youenn Fablet  <you...@apple.com>
 
         Enable service worker to use cache storage api

Modified: trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html (223937 => 223938)


--- trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html	2017-10-24 22:59:51 UTC (rev 223937)
+++ trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html	2017-10-24 23:33:03 UTC (rev 223938)
@@ -1,6 +1,7 @@
 <!DOCTYPE html>
 <html>
 <head>
+<script src=""
 <style>
 @font-face {
     font-family: Ahem;
@@ -28,8 +29,8 @@
 function typeText(text, element)
 {
     element.focus();
-    for (var i = 0; i < text.length; ++i)
-        document.execCommand("InsertText", false, text[i]);
+    for (const c of text)
+        typeCharacterCommand(c);
     element.blur();
 }
 </script>

Modified: trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html (223937 => 223938)


--- trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html	2017-10-24 22:59:51 UTC (rev 223937)
+++ trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html	2017-10-24 23:33:03 UTC (rev 223938)
@@ -1,6 +1,7 @@
 <!DOCTYPE html>
 <html>
 <head>
+<script src=""
 <style>
 @font-face {
     font-family: Ahem;
@@ -32,8 +33,8 @@
 function typeText(text, element)
 {
     element.focus();
-    for (var i = 0; i < text.length; ++i)
-        document.execCommand("InsertText", false, text[i]);
+    for (const c of text)
+        typeCharacterCommand(c);
     element.blur();
 }
 </script>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to