Title: [223980] trunk/Source/_javascript_Core
Revision
223980
Author
msab...@apple.com
Date
2017-10-25 14:12:38 -0700 (Wed, 25 Oct 2017)

Log Message

REGRESSION(r223937): Use of -fobjc-weak causes build failures with older compilers
https://bugs.webkit.org/show_bug.cgi?id=178825

Reviewed by Mark Lam.

Enable ARC for ARM64_32.  This eliminate the need for setting CLANG_ENABLE_OBJC_WEAK.

* Configurations/ToolExecutable.xcconfig:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (223979 => 223980)


--- trunk/Source/_javascript_Core/ChangeLog	2017-10-25 21:12:00 UTC (rev 223979)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-10-25 21:12:38 UTC (rev 223980)
@@ -1,3 +1,14 @@
+2017-10-25  Michael Saboff  <msab...@apple.com>
+
+        REGRESSION(r223937): Use of -fobjc-weak causes build failures with older compilers
+        https://bugs.webkit.org/show_bug.cgi?id=178825
+
+        Reviewed by Mark Lam.
+
+        Enable ARC for ARM64_32.  This eliminate the need for setting CLANG_ENABLE_OBJC_WEAK.
+
+        * Configurations/ToolExecutable.xcconfig:
+
 2017-10-25  Keith Miller  <keith_mil...@apple.com>
 
         Fix implicit cast of enum, which seems to break the windows build of unified sources.

Modified: trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig (223979 => 223980)


--- trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig	2017-10-25 21:12:00 UTC (rev 223979)
+++ trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig	2017-10-25 21:12:38 UTC (rev 223980)
@@ -50,9 +50,8 @@
 CLANG_ENABLE_OBJC_ARC_armv7s = YES;
 CLANG_ENABLE_OBJC_ARC_arm64 = YES;
 CLANG_ENABLE_OBJC_ARC_arm64e = YES;
+CLANG_ENABLE_OBJC_ARC_arm64_32 = YES;
 
-CLANG_ENABLE_OBJC_WEAK = YES;
-
 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) -isystem icu;
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to