Title: [224064] trunk/Source/WebInspectorUI
- Revision
- 224064
- Author
- nvasil...@apple.com
- Date
- 2017-10-26 16:32:04 -0700 (Thu, 26 Oct 2017)
Log Message
Web Inspector: Styles Redesign: Make "Style Attribute" text darker and non-focusable
https://bugs.webkit.org/show_bug.cgi?id=178837
Reviewed by Brian Burg.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
(.spreadsheet-css-declaration .selector.style-attribute):
Use the same shade of gray as in the "Inherited from" sections.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
Only editable selectors should be focusable.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (224063 => 224064)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-26 23:30:00 UTC (rev 224063)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-26 23:32:04 UTC (rev 224064)
@@ -1,3 +1,18 @@
+2017-10-26 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Styles Redesign: Make "Style Attribute" text darker and non-focusable
+ https://bugs.webkit.org/show_bug.cgi?id=178837
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
+ (.spreadsheet-css-declaration .selector.style-attribute):
+ Use the same shade of gray as in the "Inherited from" sections.
+
+ * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
+ (WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
+ Only editable selectors should be focusable.
+
2017-10-26 Fujii Hironori <hironori.fu...@sony.com>
[GTK] Web Inspector: Add CanvasOverview.svg and Canvas.svg
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css (224063 => 224064)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css 2017-10-26 23:30:00 UTC (rev 224063)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css 2017-10-26 23:32:04 UTC (rev 224064)
@@ -71,7 +71,7 @@
.spreadsheet-css-declaration .selector.style-attribute {
font: 12px sans-serif;
- color: hsl(0, 0%, 50%);
+ color: hsl(0, 0%, 30%);
-webkit-user-modify: read-only;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js (224063 => 224064)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js 2017-10-26 23:30:00 UTC (rev 224063)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js 2017-10-26 23:32:04 UTC (rev 224064)
@@ -63,11 +63,12 @@
this._selectorElement = document.createElement("span");
this._selectorElement.classList.add("selector");
- this._selectorElement.tabIndex = 0;
this._headerElement.append(this._selectorElement);
- if (this._style.selectorEditable)
+ if (this._style.selectorEditable) {
this._selectorTextField = new WI.SpreadsheetSelectorField(this, this._selectorElement);
+ this._selectorElement.tabIndex = 0;
+ }
this._propertiesEditor = new WI.SpreadsheetCSSStyleDeclarationEditor(this, this._style);
this._propertiesEditor.element.classList.add("properties");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
