Title: [100352] trunk/Tools
- Revision
- 100352
- Author
- t...@chromium.org
- Date
- 2011-11-15 15:50:57 -0800 (Tue, 15 Nov 2011)
Log Message
Unreviewed, try to fix ref tests failures on SL Intel bot.
It looks like ImageDiff isn't returning an image diff.
* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (100351 => 100352)
--- trunk/Tools/ChangeLog 2011-11-15 23:46:55 UTC (rev 100351)
+++ trunk/Tools/ChangeLog 2011-11-15 23:50:57 UTC (rev 100352)
@@ -1,5 +1,12 @@
2011-11-15 Tony Chang <t...@chromium.org>
+ Unreviewed, try to fix ref tests failures on SL Intel bot.
+ It looks like ImageDiff isn't returning an image diff.
+
+ * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
+
+2011-11-15 Tony Chang <t...@chromium.org>
+
Unreviewed fix of ref-tests on GTK+.
If a driver is never started, _xvfb_process is never set.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py (100351 => 100352)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-11-15 23:46:55 UTC (rev 100351)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-11-15 23:50:57 UTC (rev 100352)
@@ -58,7 +58,9 @@
writer.write_image_files(driver_output.image, expected_driver_output.image)
elif isinstance(failure, test_failures.FailureImageHashMismatch):
writer.write_image_files(driver_output.image, expected_driver_output.image)
- writer.write_image_diff_files(driver_output.image_diff)
+ # FIXME: Why is image_diff a bool on SL bot? Maybe ImageDiff isn't found?
+ if driver_output.image_diff:
+ writer.write_image_diff_files(str(driver_output.image_diff))
elif isinstance(failure, (test_failures.FailureAudioMismatch,
test_failures.FailureMissingAudio)):
writer.write_audio_files(driver_output.audio, expected_driver_output.audio)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
