Title: [224152] trunk/LayoutTests
- Revision
- 224152
- Author
- cdu...@apple.com
- Date
- 2017-10-28 10:38:00 -0700 (Sat, 28 Oct 2017)
Log Message
Update testharness.js to work around our lack of support for MessagePort in service workers
https://bugs.webkit.org/show_bug.cgi?id=178977
Reviewed by Sam Weinig.
Update testharness.js to work around our lack of support for MessagePort in service workers, similarly
to what was already done for Edge.
* web-platform-tests/resources/testharness.js:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (224151 => 224152)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-10-28 17:18:46 UTC (rev 224151)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-10-28 17:38:00 UTC (rev 224152)
@@ -1,3 +1,15 @@
+2017-10-28 Chris Dumez <cdu...@apple.com>
+
+ Update testharness.js to work around our lack of support for MessagePort in service workers
+ https://bugs.webkit.org/show_bug.cgi?id=178977
+
+ Reviewed by Sam Weinig.
+
+ Update testharness.js to work around our lack of support for MessagePort in service workers, similarly
+ to what was already done for Edge.
+
+ * web-platform-tests/resources/testharness.js:
+
2017-10-27 Chris Dumez <cdu...@apple.com>
Unskip more Service Workers tests
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/not-in-shadow-tree-expected.txt (224151 => 224152)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/not-in-shadow-tree-expected.txt 2017-10-28 17:18:46 UTC (rev 224151)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/not-in-shadow-tree-expected.txt 2017-10-28 17:38:00 UTC (rev 224152)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 2663: Error: assert_unreached: Got more than 1 load event Reached unreachable code
+CONSOLE MESSAGE: line 2659: Error: assert_unreached: Got more than 1 load event Reached unreachable code
FAIL Meta refresh only applies while in the document tree, not in a shadow tree Error: assert_unreached: Got more than 1 load event Reached unreachable code
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js (224151 => 224152)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js 2017-10-28 17:18:46 UTC (rev 224151)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js 2017-10-28 17:38:00 UTC (rev 224152)
@@ -2084,17 +2084,13 @@
var message_port;
if (is_service_worker(worker)) {
- // Microsoft Edge's implementation of ServiceWorker doesn't support MessagePort yet.
- // Feature detection isn't a straightforward option here; it's only possible in the
- // worker's script context.
- var isMicrosoftEdgeBrowser = navigator.userAgent.includes("Edge");
- if (window.MessageChannel && !isMicrosoftEdgeBrowser) {
- // The ServiceWorker's implicit MessagePort is currently not
- // reliably accessible from the ServiceWorkerGlobalScope due to
- // Blink setting MessageEvent.source to null for messages sent
- // via ServiceWorker.postMessage(). Until that's resolved,
- // create an explicit MessageChannel and pass one end to the
- // worker.
+ // The ServiceWorker's implicit MessagePort is currently not
+ // reliably accessible from the ServiceWorkerGlobalScope due to
+ // Blink setting MessageEvent.source to null for messages sent
+ // via ServiceWorker.postMessage(). Until that's resolved,
+ // create an explicit MessageChannel and pass one end to the
+ // worker.
+ if (window.MessageChannel && !!window.chrome) {
var message_channel = new MessageChannel();
message_port = message_channel.port1;
message_port.start();
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-event-expected.txt (224151 => 224152)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-event-expected.txt 2017-10-28 17:18:46 UTC (rev 224151)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-event-expected.txt 2017-10-28 17:38:00 UTC (rev 224152)
@@ -1,7 +1,7 @@
-CONSOLE MESSAGE: line 2663: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
-CONSOLE MESSAGE: line 2663: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
-CONSOLE MESSAGE: line 2663: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
-CONSOLE MESSAGE: line 2663: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
+CONSOLE MESSAGE: line 2659: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
+CONSOLE MESSAGE: line 2659: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
+CONSOLE MESSAGE: line 2659: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
+CONSOLE MESSAGE: line 2659: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
Harness Error (FAIL), message = Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/piping/general-expected.txt (224151 => 224152)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/piping/general-expected.txt 2017-10-28 17:18:46 UTC (rev 224151)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/piping/general-expected.txt 2017-10-28 17:38:00 UTC (rev 224152)
@@ -1,14 +1,14 @@
CONSOLE MESSAGE: line 16: Unhandled Promise Rejection: TypeError: The WritableStream.ready getter can only be used on instances of WritableStream
-CONSOLE MESSAGE: line 2894: TypeError: undefined is not an object (evaluating 'e.error')
+CONSOLE MESSAGE: line 2890: TypeError: undefined is not an object (evaluating 'e.error')
CONSOLE MESSAGE: Unhandled Promise Rejection: undefined
-CONSOLE MESSAGE: line 2894: TypeError: undefined is not an object (evaluating 'e.error')
+CONSOLE MESSAGE: line 2890: TypeError: undefined is not an object (evaluating 'e.error')
CONSOLE MESSAGE: Unhandled Promise Rejection: undefined
CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: cancel() called on a reader owned by no readable stream
-CONSOLE MESSAGE: line 2894: TypeError: undefined is not an object (evaluating 'e.error')
+CONSOLE MESSAGE: line 2890: TypeError: undefined is not an object (evaluating 'e.error')
CONSOLE MESSAGE: Unhandled Promise Rejection: undefined
-CONSOLE MESSAGE: line 2894: TypeError: undefined is not an object (evaluating 'e.error')
+CONSOLE MESSAGE: line 2890: TypeError: undefined is not an object (evaluating 'e.error')
CONSOLE MESSAGE: Unhandled Promise Rejection: undefined
-CONSOLE MESSAGE: line 2894: TypeError: undefined is not an object (evaluating 'e.error')
+CONSOLE MESSAGE: line 2890: TypeError: undefined is not an object (evaluating 'e.error')
CONSOLE MESSAGE: Unhandled Promise Rejection: undefined
Harness Error (FAIL), message = The WritableStream.ready getter can only be used on instances of WritableStream
Modified: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt (224151 => 224152)
--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt 2017-10-28 17:18:46 UTC (rev 224151)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt 2017-10-28 17:38:00 UTC (rev 224152)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 2663: Error: assert_equals: should scroll to fragment expected 800 but got 0
+CONSOLE MESSAGE: line 2659: Error: assert_equals: should scroll to fragment expected 800 but got 0
Harness Error (TIMEOUT), message = null
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
