Log Message
Add WEBCORE_EXPORT to CachedResourceHandleBase https://bugs.webkit.org/show_bug.cgi?id=179251
* loader/cache/CachedResourceHandle.h: (WebCore::CachedResourceHandleBase::get const): Deleted. (WebCore::CachedResourceHandleBase::operator! const): Deleted. (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType const): Deleted. (WebCore::CachedResourceHandleBase::operator=): Deleted. I'll need this soon for bug 179251, and having to touch CachedResourceHandle.h causes me to rebuild everything. Committing it separately greatly increases my debugging and comparison speed.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (224442 => 224443)
--- trunk/Source/WebCore/ChangeLog 2017-11-03 23:32:07 UTC (rev 224442)
+++ trunk/Source/WebCore/ChangeLog 2017-11-04 00:35:08 UTC (rev 224443)
@@ -1,3 +1,16 @@
+2017-11-03 Alex Christensen <achristen...@webkit.org>
+
+ Add WEBCORE_EXPORT to CachedResourceHandleBase
+ https://bugs.webkit.org/show_bug.cgi?id=179251
+
+ * loader/cache/CachedResourceHandle.h:
+ (WebCore::CachedResourceHandleBase::get const): Deleted.
+ (WebCore::CachedResourceHandleBase::operator! const): Deleted.
+ (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType const): Deleted.
+ (WebCore::CachedResourceHandleBase::operator=): Deleted.
+ I'll need this soon for bug 179251, and having to touch CachedResourceHandle.h causes me to rebuild everything.
+ Committing it separately greatly increases my debugging and comparison speed.
+
2017-11-03 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r224428, r224435, and r224440.
Modified: trunk/Source/WebCore/loader/cache/CachedResourceHandle.h (224442 => 224443)
--- trunk/Source/WebCore/loader/cache/CachedResourceHandle.h 2017-11-03 23:32:07 UTC (rev 224442)
+++ trunk/Source/WebCore/loader/cache/CachedResourceHandle.h 2017-11-04 00:35:08 UTC (rev 224443)
@@ -32,7 +32,7 @@
class CachedResource;
-class CachedResourceHandleBase {
+class WEBCORE_EXPORT CachedResourceHandleBase {
public:
~CachedResourceHandleBase();
@@ -49,7 +49,7 @@
CachedResourceHandleBase(CachedResource*);
CachedResourceHandleBase(const CachedResourceHandleBase&);
- WEBCORE_EXPORT void setResource(CachedResource*);
+ void setResource(CachedResource*);
private:
CachedResourceHandleBase& operator=(const CachedResourceHandleBase&) { return *this; }
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
