Title: [224454] trunk/Source/WebKit
- Revision
- 224454
- Author
- cdu...@apple.com
- Date
- 2017-11-03 22:19:45 -0700 (Fri, 03 Nov 2017)
Log Message
Unreviewed, rolling out r224438.
Has caused assertions on the bots
Reverted changeset:
"REGRESSION(r223718): Leaking WebProcessPool after
reconfiguration"
https://bugs.webkit.org/show_bug.cgi?id=179123
https://trac.webkit.org/changeset/224438
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (224453 => 224454)
--- trunk/Source/WebKit/ChangeLog 2017-11-04 02:12:06 UTC (rev 224453)
+++ trunk/Source/WebKit/ChangeLog 2017-11-04 05:19:45 UTC (rev 224454)
@@ -1,3 +1,16 @@
+2017-11-03 Chris Dumez <cdu...@apple.com>
+
+ Unreviewed, rolling out r224438.
+
+ Has caused assertions on the bots
+
+ Reverted changeset:
+
+ "REGRESSION(r223718): Leaking WebProcessPool after
+ reconfiguration"
+ https://bugs.webkit.org/show_bug.cgi?id=179123
+ https://trac.webkit.org/changeset/224438
+
2017-11-03 Youenn Fablet <you...@apple.com>
Requests handled by Service Worker should not go through preflighting
Modified: trunk/Source/WebKit/StorageProcess/StorageProcess.cpp (224453 => 224454)
--- trunk/Source/WebKit/StorageProcess/StorageProcess.cpp 2017-11-04 02:12:06 UTC (rev 224453)
+++ trunk/Source/WebKit/StorageProcess/StorageProcess.cpp 2017-11-04 05:19:45 UTC (rev 224454)
@@ -76,16 +76,8 @@
return true;
}
-void StorageProcess::didClose(IPC::Connection& connection)
+void StorageProcess::didClose(IPC::Connection&)
{
-#if ENABLE(SERVICE_WORKER)
- if (m_workerContextProcessConnection == &connection) {
- m_workerContextProcessConnection = nullptr;
- return;
- }
-#else
- UNUSED_PARAM(connection);
-#endif
stopRunLoop();
}
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (224453 => 224454)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-11-04 02:12:06 UTC (rev 224453)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-11-04 05:19:45 UTC (rev 224454)
@@ -935,15 +935,6 @@
if (m_processesUsingGamepads.contains(process))
processStoppedUsingGamepads(*process);
#endif
-
-#if ENABLE(SERVICE_WORKER)
- // FIXME: We should do better than this. For now, we just destroy the ServiceWorker process
- // whenever there is no regular WebContent process remaining.
- if (m_processes.size() == 1 && m_processes[0] == m_serviceWorkerProcess) {
- m_serviceWorkerProcess = nullptr;
- m_processes.clear();
- }
-#endif
}
WebProcessProxy& WebProcessPool::createNewWebProcessRespectingProcessCountLimit(WebsiteDataStore& websiteDataStore)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
