Title: [224481] trunk/Source/WebInspectorUI
Revision
224481
Author
nvasil...@apple.com
Date
2017-11-05 23:04:02 -0800 (Sun, 05 Nov 2017)

Log Message

REGRESSION (r221338): Web Inspector: NavigationBar incorrectly calculates minimumWidth
https://bugs.webkit.org/show_bug.cgi?id=179292

Reviewed by Devin Rousso.

* UserInterface/Views/NavigationBar.js:
(WI.NavigationBar.prototype._calculateMinimumWidth):
totalItemWidth was the minimumWidth of the last item.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (224480 => 224481)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-11-06 06:56:42 UTC (rev 224480)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-11-06 07:04:02 UTC (rev 224481)
@@ -1,3 +1,14 @@
+2017-11-05  Nikita Vasilyev  <nvasil...@apple.com>
+
+        REGRESSION (r221338): Web Inspector: NavigationBar incorrectly calculates minimumWidth
+        https://bugs.webkit.org/show_bug.cgi?id=179292
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/NavigationBar.js:
+        (WI.NavigationBar.prototype._calculateMinimumWidth):
+        totalItemWidth was the minimumWidth of the last item.
+
 2017-11-05  Devin Rousso  <web...@devinrousso.com>
 
         Web Inspector: Canvas Tab: selecting Frame tree element should update preview/slider, does nothing

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js (224480 => 224481)


--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js	2017-11-06 06:56:42 UTC (rev 224480)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js	2017-11-06 07:04:02 UTC (rev 224481)
@@ -427,7 +427,7 @@
         if (!wasCollapsed)
             this.element.classList.add(WI.NavigationBar.CollapsedStyleClassName);
 
-        let totalItemWidth = this._visibleNavigationItems.reduce((total, item) => item.minimumWidth, 0);
+        let totalItemWidth = this._visibleNavigationItems.reduce((total, item) => total + item.minimumWidth, 0);
 
         // Remove the collapsed style class if we were not collapsed before.
         if (!wasCollapsed)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to