Title: [224543] trunk
- Revision
- 224543
- Author
- commit-qu...@webkit.org
- Date
- 2017-11-07 12:17:55 -0800 (Tue, 07 Nov 2017)
Log Message
<video> does not respect pointer-events
https://bugs.webkit.org/show_bug.cgi?id=179378
<rdar://problem/34687668>
Patch by Antoine Quint <grao...@apple.com> on 2017-11-07
Reviewed by Simon Fraser.
Source/WebCore:
We now honor the "pointer-events" property value set on the <video> element by setting it to "inherit"
on the media controls shadow root container.
Test: media/modern-media-controls/css/pointer-events-none.html
* Modules/modern-media-controls/controls/media-controls.css:
(.media-controls-container):
LayoutTests:
Add a new test that checks that settings "pointer-events: none" on the <video> element
correctly reflects that same value on the media controls shadow root container.
* media/modern-media-controls/css/pointer-events-none-expected.txt: Added.
* media/modern-media-controls/css/pointer-events-none.html: Added.
* platform/ios/TestExpectations:
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (224542 => 224543)
--- trunk/LayoutTests/ChangeLog 2017-11-07 20:11:58 UTC (rev 224542)
+++ trunk/LayoutTests/ChangeLog 2017-11-07 20:17:55 UTC (rev 224543)
@@ -1,3 +1,18 @@
+2017-11-07 Antoine Quint <grao...@apple.com>
+
+ <video> does not respect pointer-events
+ https://bugs.webkit.org/show_bug.cgi?id=179378
+ <rdar://problem/34687668>
+
+ Reviewed by Simon Fraser.
+
+ Add a new test that checks that settings "pointer-events: none" on the <video> element
+ correctly reflects that same value on the media controls shadow root container.
+
+ * media/modern-media-controls/css/pointer-events-none-expected.txt: Added.
+ * media/modern-media-controls/css/pointer-events-none.html: Added.
+ * platform/ios/TestExpectations:
+
2017-11-07 Chris Dumez <cdu...@apple.com>
[Service Workers] Add support for "install" event
Added: trunk/LayoutTests/media/modern-media-controls/css/pointer-events-none-expected.txt (0 => 224543)
--- trunk/LayoutTests/media/modern-media-controls/css/pointer-events-none-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/css/pointer-events-none-expected.txt 2017-11-07 20:17:55 UTC (rev 224543)
@@ -0,0 +1,11 @@
+Testing that settings 'pointer-events: none' on the <video> element is respected in the media controls shadow root.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS getComputedStyle(window.internals.shadowRoot(media).querySelector('.media-controls-container')).pointerEvents is "none"
+PASS interactive is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/media/modern-media-controls/css/pointer-events-none.html (0 => 224543)
--- trunk/LayoutTests/media/modern-media-controls/css/pointer-events-none.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/css/pointer-events-none.html 2017-11-07 20:17:55 UTC (rev 224543)
@@ -0,0 +1,26 @@
+<script src=""
+<script src="" type="text/_javascript_"></script>
+<body>
+<video controls style="pointer-events: none"></video>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing that settings 'pointer-events: none' on the <video> element is respected in the media controls shadow root.");
+
+const media = document.querySelector("video");
+shouldBeEqualToString("getComputedStyle(window.internals.shadowRoot(media).querySelector('.media-controls-container')).pointerEvents", "none");
+
+let interactive = false;
+
+media.addEventListener("click", () => interactive = true);
+media.addEventListener("touchstart", () => interactive = true);
+
+pressOnElement(media, () => {
+ shouldBeFalse("interactive");
+ finishJSTest();
+});
+
+</script>
+<script src=""
+</body>
Modified: trunk/LayoutTests/platform/ios/TestExpectations (224542 => 224543)
--- trunk/LayoutTests/platform/ios/TestExpectations 2017-11-07 20:11:58 UTC (rev 224542)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2017-11-07 20:17:55 UTC (rev 224543)
@@ -172,6 +172,7 @@
platform/ios/ios/fast/text/data-detectors/phone-disabled.html [ Skip ]
platform/ios/ios/fast/text/data-detectors/phone.html [ Skip ]
platform/ios/ios/touch [ Skip ]
+media/modern-media-controls/css/pointer-events-none.html [ Skip ]
# Codecs not supported
media/media-can-play-ogg.html [ WontFix ]
Modified: trunk/Source/WebCore/ChangeLog (224542 => 224543)
--- trunk/Source/WebCore/ChangeLog 2017-11-07 20:11:58 UTC (rev 224542)
+++ trunk/Source/WebCore/ChangeLog 2017-11-07 20:17:55 UTC (rev 224543)
@@ -1,3 +1,19 @@
+2017-11-07 Antoine Quint <grao...@apple.com>
+
+ <video> does not respect pointer-events
+ https://bugs.webkit.org/show_bug.cgi?id=179378
+ <rdar://problem/34687668>
+
+ Reviewed by Simon Fraser.
+
+ We now honor the "pointer-events" property value set on the <video> element by setting it to "inherit"
+ on the media controls shadow root container.
+
+ Test: media/modern-media-controls/css/pointer-events-none.html
+
+ * Modules/modern-media-controls/controls/media-controls.css:
+ (.media-controls-container):
+
2017-11-07 Chris Dumez <cdu...@apple.com>
[Service Workers] Add support for "install" event
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css (224542 => 224543)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css 2017-11-07 20:11:58 UTC (rev 224542)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css 2017-11-07 20:17:55 UTC (rev 224543)
@@ -54,6 +54,7 @@
all: initial;
display: block;
visibility: inherit;
+ pointer-events: inherit;
-webkit-cursor-visibility: inherit;
position: relative;
will-change: z-index;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
