Title: [224620] trunk/Source/WebCore
- Revision
- 224620
- Author
- commit-qu...@webkit.org
- Date
- 2017-11-08 23:59:31 -0800 (Wed, 08 Nov 2017)
Log Message
AVSampleBufferGenerator leaks seen on leaks bot
https://bugs.webkit.org/show_bug.cgi?id=179464
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-11-08
Reviewed by Jer Noble.
* platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::ImageDecoderAVFObjC::readSampleMetadata):
(WebCore::ImageDecoderAVFObjC::createFrameImageAtIndex):
Adopt the allocation into our RetainPtr.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (224619 => 224620)
--- trunk/Source/WebCore/ChangeLog 2017-11-09 06:05:07 UTC (rev 224619)
+++ trunk/Source/WebCore/ChangeLog 2017-11-09 07:59:31 UTC (rev 224620)
@@ -1,3 +1,15 @@
+2017-11-08 Joseph Pecoraro <pecor...@apple.com>
+
+ AVSampleBufferGenerator leaks seen on leaks bot
+ https://bugs.webkit.org/show_bug.cgi?id=179464
+
+ Reviewed by Jer Noble.
+
+ * platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
+ (WebCore::ImageDecoderAVFObjC::readSampleMetadata):
+ (WebCore::ImageDecoderAVFObjC::createFrameImageAtIndex):
+ Adopt the allocation into our RetainPtr.
+
2017-11-08 Simon Fraser <simon.fra...@apple.com>
Content not painted when scrolling an overflow node inside an iframe
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm (224619 => 224620)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm 2017-11-09 06:05:07 UTC (rev 224619)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm 2017-11-09 07:59:31 UTC (rev 224620)
@@ -349,7 +349,7 @@
m_sampleData.resize(static_cast<size_t>(sampleCount));
if (!m_generator)
- m_generator = [allocAVSampleBufferGeneratorInstance() initWithAsset:m_asset.get() timebase:nil];
+ m_generator = adoptNS([allocAVSampleBufferGeneratorInstance() initWithAsset:m_asset.get() timebase:nil]);
for (size_t index = 0; index < static_cast<size_t>(sampleCount); ++index) {
auto& sampleData = m_sampleData[index];
@@ -580,7 +580,7 @@
}
if (!m_generator)
- m_generator = [allocAVSampleBufferGeneratorInstance() initWithAsset:m_asset.get() timebase:nil];
+ m_generator = adoptNS([allocAVSampleBufferGeneratorInstance() initWithAsset:m_asset.get() timebase:nil]);
RetainPtr<CGImageRef> image;
while (true) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
