Title: [224670] trunk/Source/WebCore
Revision
224670
Author
commit-qu...@webkit.org
Date
2017-11-10 00:30:28 -0800 (Fri, 10 Nov 2017)

Log Message

WebInjectedScriptHost.cpp: warning: variable ‘scope’ set but not used
https://bugs.webkit.org/show_bug.cgi?id=179524

Patch by Fujii Hironori <hironori.fu...@sony.com> on 2017-11-10
Reviewed by Joseph Pecoraro.

r224606 has introduced a new compilation warning if not
ENABLE(PAYMENT_REQUEST).

No new tests (No behavior change).

* inspector/WebInjectedScriptHost.cpp:
(WebCore::WebInjectedScriptHost::getInternalProperties): Do not
define the variable 'scope' if not ENABLE(PAYMENT_REQUEST). Marked
a variable 'vm' with UNUSED_PARAM.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (224669 => 224670)


--- trunk/Source/WebCore/ChangeLog	2017-11-10 08:18:02 UTC (rev 224669)
+++ trunk/Source/WebCore/ChangeLog	2017-11-10 08:30:28 UTC (rev 224670)
@@ -1,3 +1,20 @@
+2017-11-10  Fujii Hironori  <hironori.fu...@sony.com>
+
+        WebInjectedScriptHost.cpp: warning: variable ‘scope’ set but not used
+        https://bugs.webkit.org/show_bug.cgi?id=179524
+
+        Reviewed by Joseph Pecoraro.
+
+        r224606 has introduced a new compilation warning if not
+        ENABLE(PAYMENT_REQUEST).
+
+        No new tests (No behavior change).
+
+        * inspector/WebInjectedScriptHost.cpp:
+        (WebCore::WebInjectedScriptHost::getInternalProperties): Do not
+        define the variable 'scope' if not ENABLE(PAYMENT_REQUEST). Marked
+        a variable 'vm' with UNUSED_PARAM.
+
 2017-11-10  Zan Dobersek  <zdober...@igalia.com>
 
         [Cairo] Start grouping Cairo GraphicsContext operations behind a separate interface

Modified: trunk/Source/WebCore/inspector/WebInjectedScriptHost.cpp (224669 => 224670)


--- trunk/Source/WebCore/inspector/WebInjectedScriptHost.cpp	2017-11-10 08:18:02 UTC (rev 224669)
+++ trunk/Source/WebCore/inspector/WebInjectedScriptHost.cpp	2017-11-10 08:30:28 UTC (rev 224670)
@@ -162,9 +162,9 @@
 
 JSValue WebInjectedScriptHost::getInternalProperties(VM& vm, ExecState* exec, JSC::JSValue value)
 {
+#if ENABLE(PAYMENT_REQUEST)
     auto scope = DECLARE_THROW_SCOPE(vm);
 
-#if ENABLE(PAYMENT_REQUEST)
     if (PaymentRequest* paymentRequest = JSPaymentRequest::toWrapped(vm, value)) {
         unsigned index = 0;
         auto* array = constructEmptyArray(exec, nullptr);
@@ -175,6 +175,7 @@
         return array;
     }
 #else
+    UNUSED_PARAM(vm);
     UNUSED_PARAM(exec);
     UNUSED_PARAM(value);
 #endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to