Title: [224835] trunk/Source/WebKit
- Revision
- 224835
- Author
- dba...@webkit.org
- Date
- 2017-11-14 12:48:49 -0800 (Tue, 14 Nov 2017)
Log Message
Mark WebChromeClient::requestStorageAccess() as final
https://bugs.webkit.org/show_bug.cgi?id=179673
Reviewed by Sam Weinig.
Mark WebChromeClient::requestStorageAccess() as final so that it overrides the virtual function
in ChromeClient with the same name and hence we actually call it through a ChromeClient pointer.
* WebProcess/WebCoreSupport/WebChromeClient.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (224834 => 224835)
--- trunk/Source/WebKit/ChangeLog 2017-11-14 20:38:55 UTC (rev 224834)
+++ trunk/Source/WebKit/ChangeLog 2017-11-14 20:48:49 UTC (rev 224835)
@@ -1,3 +1,15 @@
+2017-11-14 Daniel Bates <daba...@apple.com>
+
+ Mark WebChromeClient::requestStorageAccess() as final
+ https://bugs.webkit.org/show_bug.cgi?id=179673
+
+ Reviewed by Sam Weinig.
+
+ Mark WebChromeClient::requestStorageAccess() as final so that it overrides the virtual function
+ in ChromeClient with the same name and hence we actually call it through a ChromeClient pointer.
+
+ * WebProcess/WebCoreSupport/WebChromeClient.h:
+
2017-11-14 Youenn Fablet <you...@apple.com>
WebSWClientConnection should do IPC to StorageProcess if its WebSWOriginTable is not yet initialized
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h (224834 => 224835)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h 2017-11-14 20:38:55 UTC (rev 224834)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h 2017-11-14 20:48:49 UTC (rev 224835)
@@ -342,7 +342,7 @@
void didInvalidateDocumentMarkerRects() final;
- void requestStorageAccess(String&& subFrameHost, String&& topFrameHost, WTF::Function<void (bool)>&&);
+ void requestStorageAccess(String&& subFrameHost, String&& topFrameHost, WTF::Function<void (bool)>&&) final;
String m_cachedToolTip;
mutable RefPtr<WebFrame> m_cachedFrameSetLargestFrame;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
