Title: [225267] trunk/Source/WebKit
- Revision
- 225267
- Author
- mcatanz...@igalia.com
- Date
- 2017-11-29 09:06:58 -0800 (Wed, 29 Nov 2017)
Log Message
REGRESSION(r218064): [GTK] Broke entering fullscreen mode in debug builds
https://bugs.webkit.org/show_bug.cgi?id=180120
Reviewed by Carlos Garcia Campos.
These assertions need to be swapped. Fixes /webkit2/WebKitWebView/fullscreen in debug mode.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseEnterFullScreen):
(webkitWebViewBaseExitFullScreen):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (225266 => 225267)
--- trunk/Source/WebKit/ChangeLog 2017-11-29 14:30:27 UTC (rev 225266)
+++ trunk/Source/WebKit/ChangeLog 2017-11-29 17:06:58 UTC (rev 225267)
@@ -1,3 +1,16 @@
+2017-11-29 Michael Catanzaro <mcatanz...@igalia.com>
+
+ REGRESSION(r218064): [GTK] Broke entering fullscreen mode in debug builds
+ https://bugs.webkit.org/show_bug.cgi?id=180120
+
+ Reviewed by Carlos Garcia Campos.
+
+ These assertions need to be swapped. Fixes /webkit2/WebKitWebView/fullscreen in debug mode.
+
+ * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+ (webkitWebViewBaseEnterFullScreen):
+ (webkitWebViewBaseExitFullScreen):
+
2017-11-29 Zan Dobersek <zdober...@igalia.com>
[CoordGraphics] Rename CoordinatedBuffer to Nicosia::Buffer
Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp (225266 => 225267)
--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp 2017-11-29 14:30:27 UTC (rev 225266)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp 2017-11-29 17:06:58 UTC (rev 225267)
@@ -1304,7 +1304,7 @@
{
#if ENABLE(FULLSCREEN_API)
WebKitWebViewBasePrivate* priv = webkitWebViewBase->priv;
- ASSERT(priv->fullScreenModeActive);
+ ASSERT(!priv->fullScreenModeActive);
WebFullScreenManagerProxy* fullScreenManagerProxy = priv->pageProxy->fullScreenManager();
fullScreenManagerProxy->willEnterFullScreen();
@@ -1322,7 +1322,7 @@
{
#if ENABLE(FULLSCREEN_API)
WebKitWebViewBasePrivate* priv = webkitWebViewBase->priv;
- ASSERT(!priv->fullScreenModeActive);
+ ASSERT(priv->fullScreenModeActive);
WebFullScreenManagerProxy* fullScreenManagerProxy = priv->pageProxy->fullScreenManager();
fullScreenManagerProxy->willExitFullScreen();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
