Title: [225493] trunk/JSTests
- Revision
- 225493
- Author
- jfbast...@apple.com
- Date
- 2017-12-04 14:06:50 -0800 (Mon, 04 Dec 2017)
Log Message
Proxy all functions, except the $ objects
https://bugs.webkit.org/show_bug.cgi?id=180375
Reviewed by Saam Barati.
It looks like this test may have broken some executions because I
call some internal objects. Explicitly ignore objects whose name
starts with "$" because it's a bad idea anyways.
* stress/proxy-all-the-parameters.js:
(generateObjects):
(get throw):
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (225492 => 225493)
--- trunk/JSTests/ChangeLog 2017-12-04 22:00:24 UTC (rev 225492)
+++ trunk/JSTests/ChangeLog 2017-12-04 22:06:50 UTC (rev 225493)
@@ -1,3 +1,18 @@
+2017-12-04 JF Bastien <jfbast...@apple.com>
+
+ Proxy all functions, except the $ objects
+ https://bugs.webkit.org/show_bug.cgi?id=180375
+
+ Reviewed by Saam Barati.
+
+ It looks like this test may have broken some executions because I
+ call some internal objects. Explicitly ignore objects whose name
+ starts with "$" because it's a bad idea anyways.
+
+ * stress/proxy-all-the-parameters.js:
+ (generateObjects):
+ (get throw):
+
2017-12-04 Saam Barati <sbar...@apple.com>
We need to leave room on the top of the stack for the FTL TailCall slow path so it doesn't overwrite things we want to retrieve when doing a stack walk when throwing an exception
Modified: trunk/JSTests/stress/proxy-all-the-parameters.js (225492 => 225493)
--- trunk/JSTests/stress/proxy-all-the-parameters.js 2017-12-04 22:00:24 UTC (rev 225492)
+++ trunk/JSTests/stress/proxy-all-the-parameters.js 2017-12-04 22:06:50 UTC (rev 225493)
@@ -1,7 +1,5 @@
const verbose = false;
-const ignore = ['quit', 'readline', 'waitForReport', 'flashHeapAccess', 'leaving', 'getReport'];
-
function isPropertyOfType(obj, name, type) {
let desc;
desc = Object.getOwnPropertyDescriptor(obj, name)
@@ -22,6 +20,8 @@
return;
let obj_names = getProperties(root, 'object');
for (let obj_name of obj_names) {
+ if (obj_name.startsWith('$'))
+ continue; // Ignore internal objects.
let obj = root[obj_name];
yield obj;
yield* generateObjects(obj, level + 1);
@@ -44,8 +44,6 @@
for (let o of getObjects()) {
for (let f of getFunctions(o)) {
- if (ignore.includes(f))
- continue;
const arityPlusOne = o[f].length + 1;
if (verbose)
print(`Calling ${o}['${f}'](${Array(arityPlusOne).fill("thrower")})`);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
