Title: [225579] trunk/Source/_javascript_Core
- Revision
- 225579
- Author
- sbar...@apple.com
- Date
- 2017-12-06 10:58:00 -0800 (Wed, 06 Dec 2017)
Log Message
ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() in void JSC::sanitizeStackForVM(JSC::VM *)
https://bugs.webkit.org/show_bug.cgi?id=180438
<rdar://problem/35862342>
Reviewed by Yusuke Suzuki.
A couple inspector methods that take stacktraces need
to grab the JSLock.
* inspector/ScriptCallStackFactory.cpp:
(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (225578 => 225579)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-06 18:55:49 UTC (rev 225578)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-06 18:58:00 UTC (rev 225579)
@@ -1,3 +1,18 @@
+2017-12-06 Saam Barati <sbar...@apple.com>
+
+ ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() in void JSC::sanitizeStackForVM(JSC::VM *)
+ https://bugs.webkit.org/show_bug.cgi?id=180438
+ <rdar://problem/35862342>
+
+ Reviewed by Yusuke Suzuki.
+
+ A couple inspector methods that take stacktraces need
+ to grab the JSLock.
+
+ * inspector/ScriptCallStackFactory.cpp:
+ (Inspector::createScriptCallStack):
+ (Inspector::createScriptCallStackForConsole):
+
2017-12-05 Stephan Szabo <stephan.sz...@sony.com>
Switch windows build to Visual Studio 2017
Modified: trunk/Source/_javascript_Core/inspector/ScriptCallStackFactory.cpp (225578 => 225579)
--- trunk/Source/_javascript_Core/inspector/ScriptCallStackFactory.cpp 2017-12-06 18:55:49 UTC (rev 225578)
+++ trunk/Source/_javascript_Core/inspector/ScriptCallStackFactory.cpp 2017-12-06 18:58:00 UTC (rev 225579)
@@ -89,6 +89,7 @@
if (!exec)
return ScriptCallStack::create();
+ JSLockHolder locker(exec);
Vector<ScriptCallFrame> frames;
CallFrame* frame = exec->vm().topCallFrame;
@@ -103,6 +104,7 @@
if (!exec)
return ScriptCallStack::create();
+ JSLockHolder locker(exec);
Vector<ScriptCallFrame> frames;
CallFrame* frame = exec->vm().topCallFrame;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
