Title: [226151] trunk/Source/WebInspectorUI
- Revision
- 226151
- Author
- [email protected]
- Date
- 2017-12-19 15:40:16 -0800 (Tue, 19 Dec 2017)
Log Message
Web Inspector: Network Table - Update the Time column to include the total duration not just the download duration
https://bugs.webkit.org/show_bug.cgi?id=180998
<rdar://problem/36140424>
Reviewed by Matt Baker.
* UserInterface/Models/Resource.js:
(WI.Resource.prototype.get totalDuration):
(WI.Resource.prototype.get duration): Deleted.
Rename and group getters to be clearer.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._entryForResource):
Use the totalDuration for the network table time column.
* UserInterface/Views/ResourceTimelineDataGridNode.js:
(WI.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar graphDataSource.get secondsPerPixel):
Using the download duration was incorrect here.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (226150 => 226151)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-12-19 23:16:09 UTC (rev 226150)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-12-19 23:40:16 UTC (rev 226151)
@@ -1,3 +1,24 @@
+2017-12-19 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Network Table - Update the Time column to include the total duration not just the download duration
+ https://bugs.webkit.org/show_bug.cgi?id=180998
+ <rdar://problem/36140424>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Models/Resource.js:
+ (WI.Resource.prototype.get totalDuration):
+ (WI.Resource.prototype.get duration): Deleted.
+ Rename and group getters to be clearer.
+
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView.prototype._entryForResource):
+ Use the totalDuration for the network table time column.
+
+ * UserInterface/Views/ResourceTimelineDataGridNode.js:
+ (WI.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar graphDataSource.get secondsPerPixel):
+ Using the download duration was incorrect here.
+
2017-12-19 Devin Rousso <[email protected]>
Web Inspector: Styles Redesign: Typing semicolon at the end of value should move to the next property
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (226150 => 226151)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2017-12-19 23:16:09 UTC (rev 226150)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2017-12-19 23:40:16 UTC (rev 226151)
@@ -532,11 +532,6 @@
return this.timingData.responseEnd || this.lastDataReceivedTimestamp || this.responseReceivedTimestamp || this.lastRedirectReceivedTimestamp || this.requestSentTimestamp;
}
- get duration()
- {
- return this.timingData.responseEnd - this.timingData.requestStart;
- }
-
get latency()
{
return this.timingData.responseStart - this.timingData.requestStart;
@@ -547,6 +542,11 @@
return this.timingData.responseEnd - this.timingData.responseStart;
}
+ get totalDuration()
+ {
+ return this.timingData.responseEnd - this.timingData.startTime;
+ }
+
get cached()
{
return this._cached;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (226150 => 226151)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2017-12-19 23:16:09 UTC (rev 226150)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2017-12-19 23:40:16 UTC (rev 226151)
@@ -1196,7 +1196,7 @@
cached: resource.cached,
resourceSize: resource.size,
transferSize: !isNaN(resource.networkTotalTransferSize) ? resource.networkTotalTransferSize : resource.estimatedTotalTransferSize,
- time: resource.duration,
+ time: resource.totalDuration,
protocol: resource.protocol,
priority: resource.priority,
remoteAddress: resource.remoteAddress,
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js (226150 => 226151)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2017-12-19 23:16:09 UTC (rev 226150)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2017-12-19 23:40:16 UTC (rev 226151)
@@ -384,7 +384,7 @@
popoverContentElement.appendChild(popoverDataGrid.element);
let graphDataSource = {
- get secondsPerPixel() { return resource.duration / WI.ResourceTimelineDataGridNode.PopoverGraphColumnWidthPixels; },
+ get secondsPerPixel() { return resource.totalDuration / WI.ResourceTimelineDataGridNode.PopoverGraphColumnWidthPixels; },
get zeroTime() { return resource.firstTimestamp; },
get startTime() { return resource.firstTimestamp; },
get currentTime() { return this.endTime; },
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
