Title: [226193] trunk
- Revision
- 226193
- Author
- commit-qu...@webkit.org
- Date
- 2017-12-20 11:29:08 -0800 (Wed, 20 Dec 2017)
Log Message
LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179137
<rdar://problem/35337335>
Patch by Youenn Fablet <you...@apple.com> on 2017-12-20
Reviewed by Chris Dumez.
Source/WebCore:
Covered by unflaked test.
* workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::postTaskToLoader): ThreadableBlobRegistry is using callOnMainThread.
Use it also for postTaskToLoader so that there is no race condition between registering a blob and reading it.
LayoutTests:
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (226192 => 226193)
--- trunk/LayoutTests/ChangeLog 2017-12-20 19:19:13 UTC (rev 226192)
+++ trunk/LayoutTests/ChangeLog 2017-12-20 19:29:08 UTC (rev 226193)
@@ -1,3 +1,13 @@
+2017-12-20 Youenn Fablet <you...@apple.com>
+
+ LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=179137
+ <rdar://problem/35337335>
+
+ Reviewed by Chris Dumez.
+
+ * TestExpectations:
+
2017-12-20 Alicia Boya García <ab...@igalia.com>
[GTK] Test gardening
Modified: trunk/LayoutTests/TestExpectations (226192 => 226193)
--- trunk/LayoutTests/TestExpectations 2017-12-20 19:19:13 UTC (rev 226192)
+++ trunk/LayoutTests/TestExpectations 2017-12-20 19:29:08 UTC (rev 226193)
@@ -167,7 +167,6 @@
webkit.org/b/179342 http/tests/workers/service/registration-task-queue-scheduling-1.html [ Pass Failure ]
http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
imported/w3c/web-platform-tests/service-workers/service-worker/about-blank-replacement.https.html [ Pass Failure ]
-webkit.org/b/179137 imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html [ Pass Failure ]
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ DumpJSConsoleLogInStdErr Pass Failure ]
webkit.org/b/179248 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html [ Pass Failure ]
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (226192 => 226193)
--- trunk/Source/WebCore/ChangeLog 2017-12-20 19:19:13 UTC (rev 226192)
+++ trunk/Source/WebCore/ChangeLog 2017-12-20 19:29:08 UTC (rev 226193)
@@ -1,5 +1,19 @@
2017-12-20 Youenn Fablet <you...@apple.com>
+ LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=179137
+ <rdar://problem/35337335>
+
+ Reviewed by Chris Dumez.
+
+ Covered by unflaked test.
+
+ * workers/service/context/ServiceWorkerThreadProxy.cpp:
+ (WebCore::ServiceWorkerThreadProxy::postTaskToLoader): ThreadableBlobRegistry is using callOnMainThread.
+ Use it also for postTaskToLoader so that there is no race condition between registering a blob and reading it.
+
+2017-12-20 Youenn Fablet <you...@apple.com>
+
Support service worker interception of request with blob body
https://bugs.webkit.org/show_bug.cgi?id=181035
Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp (226192 => 226193)
--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp 2017-12-20 19:19:13 UTC (rev 226192)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp 2017-12-20 19:29:08 UTC (rev 226193)
@@ -32,6 +32,7 @@
#include "FrameLoader.h"
#include "MainFrame.h"
#include <pal/SessionID.h>
+#include <wtf/MainThread.h>
#include <wtf/RunLoop.h>
namespace WebCore {
@@ -80,7 +81,7 @@
void ServiceWorkerThreadProxy::postTaskToLoader(ScriptExecutionContext::Task&& task)
{
- RunLoop::main().dispatch([task = WTFMove(task), this, protectedThis = makeRef(*this)] () mutable {
+ callOnMainThread([task = WTFMove(task), this, protectedThis = makeRef(*this)] () mutable {
task.performTask(m_document.get());
});
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
