Title: [226206] trunk/Source/WebKit
- Revision
- 226206
- Author
- commit-qu...@webkit.org
- Date
- 2017-12-20 17:39:08 -0800 (Wed, 20 Dec 2017)
Log Message
Crash when clearing std::optional<WebKit::WebServiceWorkerFetchTaskClient::BlobLoader>
https://bugs.webkit.org/show_bug.cgi?id=181061
Patch by Youenn Fablet <you...@apple.com> on 2017-12-20
Reviewed by Alex Christensen.
* WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didFinishBlobLoading): moving the object to not destroy 'this' too soon.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (226205 => 226206)
--- trunk/Source/WebKit/ChangeLog 2017-12-21 01:10:52 UTC (rev 226205)
+++ trunk/Source/WebKit/ChangeLog 2017-12-21 01:39:08 UTC (rev 226206)
@@ -1,5 +1,15 @@
2017-12-20 Youenn Fablet <you...@apple.com>
+ Crash when clearing std::optional<WebKit::WebServiceWorkerFetchTaskClient::BlobLoader>
+ https://bugs.webkit.org/show_bug.cgi?id=181061
+
+ Reviewed by Alex Christensen.
+
+ * WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
+ (WebKit::WebServiceWorkerFetchTaskClient::didFinishBlobLoading): moving the object to not destroy 'this' too soon.
+
+2017-12-20 Youenn Fablet <you...@apple.com>
+
Support service worker interception of request with blob body
https://bugs.webkit.org/show_bug.cgi?id=181035
Modified: trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp (226205 => 226206)
--- trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp 2017-12-21 01:10:52 UTC (rev 226205)
+++ trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp 2017-12-21 01:39:08 UTC (rev 226206)
@@ -114,7 +114,7 @@
{
didFinish();
- m_blobLoader = std::nullopt;
+ std::exchange(m_blobLoader, std::nullopt);
}
void WebServiceWorkerFetchTaskClient::didFail()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
