Title: [226493] trunk/Tools
- Revision
- 226493
- Author
- sbar...@apple.com
- Date
- 2018-01-07 14:22:52 -0800 (Sun, 07 Jan 2018)
Log Message
Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
https://bugs.webkit.org/show_bug.cgi?id=181372
Reviewed by Filip Pizlo.
Adding these sorting modes makes it easier to analyze functions
that recompile a lot and exit a lot.
* Scripts/display-profiler-output:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (226492 => 226493)
--- trunk/Tools/ChangeLog 2018-01-07 06:31:14 UTC (rev 226492)
+++ trunk/Tools/ChangeLog 2018-01-07 22:22:52 UTC (rev 226493)
@@ -1,3 +1,15 @@
+2018-01-07 Saam Barati <sbar...@apple.com>
+
+ Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
+ https://bugs.webkit.org/show_bug.cgi?id=181372
+
+ Reviewed by Filip Pizlo.
+
+ Adding these sorting modes makes it easier to analyze functions
+ that recompile a lot and exit a lot.
+
+ * Scripts/display-profiler-output:
+
2018-01-06 Julien Brianceau <julien.brianc...@gmail.com>
Unreviewed, remove my Cisco email from contributors.json
Modified: trunk/Tools/Scripts/display-profiler-output (226492 => 226493)
--- trunk/Tools/Scripts/display-profiler-output 2018-01-07 06:31:14 UTC (rev 226492)
+++ trunk/Tools/Scripts/display-profiler-output 2018-01-07 22:22:52 UTC (rev 226493)
@@ -650,6 +650,10 @@
b.totalMaxTopExecutionCount <=> a.totalMaxTopExecutionCount
when :machine
b.totalMaxBottomExecutionCount <=> a.totalMaxBottomExecutionCount
+ when :exits
+ b.totalExitCount <=> a.totalExitCount
+ when :compiles
+ b.compilations.size <=> a.compilations.size
else
raise
end
@@ -777,6 +781,10 @@
when "full", "f"
if args[0] and (args[0] == "m" or args[0] == "machine")
summary(:full, :machine)
+ elsif args[0] and (args[0] == "e" or args[0] == "exits")
+ summary(:full, :exits)
+ elsif args[0] and (args[0] == "c" or args[0] == "compiles")
+ summary(:full, :compiles)
else
summary(:full, :bytecode)
end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes