Title: [226671] trunk/Source/WebInspectorUI
- Revision
- 226671
- Author
- ross.kirsl...@sony.com
- Date
- 2018-01-09 18:43:36 -0800 (Tue, 09 Jan 2018)
Log Message
Web Inspector: Layers sidebar shows popover on selection even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=181465
Reviewed by Matt Baker.
* UserInterface/Views/LayerDetailsSidebarPanel.js:
(WI.LayerDetailsSidebarPanel.prototype.selectNodeByLayerId):
Have sidebar show itself if necessary before displaying popover.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (226670 => 226671)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-01-10 02:37:05 UTC (rev 226670)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-01-10 02:43:36 UTC (rev 226671)
@@ -1,3 +1,14 @@
+2018-01-09 Ross Kirsling <ross.kirsl...@sony.com>
+
+ Web Inspector: Layers sidebar shows popover on selection even when collapsed
+ https://bugs.webkit.org/show_bug.cgi?id=181465
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/LayerDetailsSidebarPanel.js:
+ (WI.LayerDetailsSidebarPanel.prototype.selectNodeByLayerId):
+ Have sidebar show itself if necessary before displaying popover.
+
2018-01-08 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Find next / previous within a resource content view does not have bouncy highlight when editor scrolls
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js (226670 => 226671)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js 2018-01-10 02:37:05 UTC (rev 226670)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js 2018-01-10 02:43:36 UTC (rev 226671)
@@ -63,6 +63,9 @@
selectNodeByLayerId(layerId)
{
+ if (!this.parentSidebar)
+ return;
+
let node = this._dataGridNodesByLayerId.get(layerId);
if (node === this._dataGrid.selectedNode)
return;
@@ -69,6 +72,8 @@
const suppressEvent = true;
if (node) {
+ this.parentSidebar.selectedSidebarPanel = this;
+ this.parentSidebar.collapsed = false;
node.revealAndSelect(suppressEvent);
this._showPopoverForSelectedNode();
} else if (this._dataGrid.selectedNode)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
