Title: [226897] trunk/Tools
- Revision
- 226897
- Author
- achristen...@apple.com
- Date
- 2018-01-12 10:26:53 -0800 (Fri, 12 Jan 2018)
Log Message
REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
https://bugs.webkit.org/show_bug.cgi?id=181595
This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
I change the < and > to $ to make this test pass and continue to test what it used to.
* TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
* TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
(-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (226896 => 226897)
--- trunk/Tools/ChangeLog 2018-01-12 17:39:49 UTC (rev 226896)
+++ trunk/Tools/ChangeLog 2018-01-12 18:26:53 UTC (rev 226897)
@@ -1,3 +1,16 @@
+2018-01-12 Alex Christensen <achristen...@webkit.org>
+
+ REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
+ https://bugs.webkit.org/show_bug.cgi?id=181595
+
+ This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
+ It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
+ I change the < and > to $ to make this test pass and continue to test what it used to.
+
+ * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
+ * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
+ (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
+
2018-01-11 Keith Miller <keith_mil...@apple.com>
Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html (226896 => 226897)
--- trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html 2018-01-12 17:39:49 UTC (rev 226896)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html 2018-01-12 18:26:53 UTC (rev 226897)
@@ -3,7 +3,7 @@
<head>
</head>
<body>
- <a id="href" href=""
+ <a id="href" href=""
<script>
var element = document.getElementById("href");
element.click();
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm (226896 => 226897)
--- trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm 2018-01-12 17:39:49 UTC (rev 226896)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm 2018-01-12 18:26:53 UTC (rev 226897)
@@ -50,7 +50,7 @@
EXPECT_WK_STREQ(error.domain, @"WebKitErrorDomain");
EXPECT_EQ(error.code, WebKitErrorCannotShowURL);
- static char literal[] = "https://www.example.com<>/";
+ static char literal[] = "https://www.example.com$/";
NSURL *failedURL = WebCore::URLWithData([NSData dataWithBytes:literal length:strlen(literal)], nil);
EXPECT_TRUE([error.userInfo[@"NSErrorFailingURLKey"] isEqual:failedURL]);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
