Title: [227463] trunk/Source/WebInspectorUI
- Revision
- 227463
- Author
- commit-qu...@webkit.org
- Date
- 2018-01-23 16:46:39 -0800 (Tue, 23 Jan 2018)
Log Message
Web Inspector: Network's columns shake when scrolling at non-default zoom level
https://bugs.webkit.org/show_bug.cgi?id=181998
<rdar://problem/36449808>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2018-01-23
Reviewed by Matt Baker.
* UserInterface/Views/Table.js:
When zoomed the bounding client rect values were fractional, which was
unexpected by this area of code. Floor the values to get a value we expect
to be able to evenly distribute.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (227462 => 227463)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-01-24 00:40:12 UTC (rev 227462)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-01-24 00:46:39 UTC (rev 227463)
@@ -1,3 +1,16 @@
+2018-01-23 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Network's columns shake when scrolling at non-default zoom level
+ https://bugs.webkit.org/show_bug.cgi?id=181998
+ <rdar://problem/36449808>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/Table.js:
+ When zoomed the bounding client rect values were fractional, which was
+ unexpected by this area of code. Floor the values to get a value we expect
+ to be able to evenly distribute.
+
2018-01-22 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: Styles Redesign: data corruption when updating values quickly
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (227462 => 227463)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2018-01-24 00:40:12 UTC (rev 227462)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2018-01-24 00:46:39 UTC (rev 227463)
@@ -709,8 +709,8 @@
if (isNaN(this._cachedWidth)) {
let boundingClientRect = this._scrollContainerElement.getBoundingClientRect();
- this._cachedWidth = boundingClientRect.width;
- this._cachedHeight = boundingClientRect.height;
+ this._cachedWidth = Math.floor(boundingClientRect.width);
+ this._cachedHeight = Math.floor(boundingClientRect.height);
}
// Not visible yet.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
