Title: [227597] trunk/Source/_javascript_Core
Revision
227597
Author
commit-qu...@webkit.org
Date
2018-01-25 01:06:29 -0800 (Thu, 25 Jan 2018)

Log Message

undefined reference to 'JSC::B3::BasicBlock::fallThrough() const
https://bugs.webkit.org/show_bug.cgi?id=180637

Patch by Alejandro G. Castro <a...@igalia.com> on 2018-01-25
Reviewed by Michael Catanzaro.

We need to make sure the implementation of the inline functions is
compiled when we compile the code using the function, now that the
compilation is divided, or we could end up with undefined symbols
when the declaration is not inlined, at least with some compilers
and optimizations enabled -O2.

* b3/B3SwitchValue.cpp: replace the include.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227596 => 227597)


--- trunk/Source/_javascript_Core/ChangeLog	2018-01-25 07:59:07 UTC (rev 227596)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-25 09:06:29 UTC (rev 227597)
@@ -1,3 +1,18 @@
+2018-01-25  Alejandro G. Castro  <a...@igalia.com>
+
+        undefined reference to 'JSC::B3::BasicBlock::fallThrough() const
+        https://bugs.webkit.org/show_bug.cgi?id=180637
+
+        Reviewed by Michael Catanzaro.
+
+        We need to make sure the implementation of the inline functions is
+        compiled when we compile the code using the function, now that the
+        compilation is divided, or we could end up with undefined symbols
+        when the declaration is not inlined, at least with some compilers
+        and optimizations enabled -O2.
+
+        * b3/B3SwitchValue.cpp: replace the include.
+
 2018-01-20  Filip Pizlo  <fpi...@apple.com>
 
         JSC GC should support TLCs (thread local caches)

Modified: trunk/Source/_javascript_Core/b3/B3SwitchValue.cpp (227596 => 227597)


--- trunk/Source/_javascript_Core/b3/B3SwitchValue.cpp	2018-01-25 07:59:07 UTC (rev 227596)
+++ trunk/Source/_javascript_Core/b3/B3SwitchValue.cpp	2018-01-25 09:06:29 UTC (rev 227597)
@@ -28,7 +28,7 @@
 
 #if ENABLE(B3_JIT)
 
-#include "B3BasicBlock.h"
+#include "B3BasicBlockInlines.h"
 #include <wtf/ListDump.h>
 
 namespace JSC { namespace B3 {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to