Title: [227927] trunk/Source/WebKit
- Revision
- 227927
- Author
- [email protected]
- Date
- 2018-01-31 13:39:49 -0800 (Wed, 31 Jan 2018)
Log Message
Occasional null deref under WebPageProxy::updateBackingStoreDiscardableState()
https://bugs.webkit.org/show_bug.cgi?id=182349
<rdar://problem/27822258>
Reviewed by Simon Fraser.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
m_drawingArea can be null during process launch and relaunch.
Cocoa ports don't use the result of setBackingStoreIsDiscardable(),
but they do run this code to keep it up to date.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (227926 => 227927)
--- trunk/Source/WebKit/ChangeLog 2018-01-31 21:07:36 UTC (rev 227926)
+++ trunk/Source/WebKit/ChangeLog 2018-01-31 21:39:49 UTC (rev 227927)
@@ -1,3 +1,18 @@
+2018-01-31 Tim Horton <[email protected]>
+
+ Occasional null deref under WebPageProxy::updateBackingStoreDiscardableState()
+ https://bugs.webkit.org/show_bug.cgi?id=182349
+ <rdar://problem/27822258>
+
+ Reviewed by Simon Fraser.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::updateBackingStoreDiscardableState):
+ m_drawingArea can be null during process launch and relaunch.
+
+ Cocoa ports don't use the result of setBackingStoreIsDiscardable(),
+ but they do run this code to keep it up to date.
+
2018-01-31 Michael Catanzaro <[email protected]>
[GTK] Move gir and typelib generation into ENABLE_INTROSPECTION conditional
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (227926 => 227927)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-01-31 21:07:36 UTC (rev 227926)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-01-31 21:39:49 UTC (rev 227927)
@@ -6286,6 +6286,9 @@
{
ASSERT(isValid());
+ if (!m_drawingArea)
+ return;
+
bool isDiscardable;
if (!m_process->isResponsive())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
