Title: [227971] trunk/Tools
- Revision
- 227971
- Author
- aakash_j...@apple.com
- Date
- 2018-02-01 09:30:26 -0800 (Thu, 01 Feb 2018)
Log Message
Bubbles intermittently disappear from bot watchers dashboard
https://bugs.webkit.org/show_bug.cgi?id=182085
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (227970 => 227971)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2018-02-01 17:27:06 UTC (rev 227970)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2018-02-01 17:30:26 UTC (rev 227971)
@@ -162,11 +162,11 @@
if (!this.failed)
return undefined;
+ if (!this.queue.buildbot.VERSION_LESS_THAN_09)
+ return this.queue.buildbot.buildPageURLForIteration(this);
+
console.assert(this._firstFailedStep);
- if (!this._firstFailedStep.logs)
- return this.queue.buildbot.buildPageURLForIteration(this);
-
for (var i = 0; i < this._firstFailedStep.logs.length; ++i) {
if (this._firstFailedStep.logs[i][0] == kind)
return this._firstFailedStep.logs[i][1];
Modified: trunk/Tools/ChangeLog (227970 => 227971)
--- trunk/Tools/ChangeLog 2018-02-01 17:27:06 UTC (rev 227970)
+++ trunk/Tools/ChangeLog 2018-02-01 17:30:26 UTC (rev 227971)
@@ -1,3 +1,15 @@
+2018-02-01 Aakash Jain <aakash_j...@apple.com>
+
+ Bubbles intermittently disappear from bot watchers dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=182085
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
+ Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
+ confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
+
2018-02-01 Carlos Garcia Campos <cgar...@igalia.com>
[GTK] Problem with Washington Post images
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
