Title: [228508] trunk/Source/WebCore
- Revision
- 228508
- Author
- [email protected]
- Date
- 2018-02-15 02:11:26 -0800 (Thu, 15 Feb 2018)
Log Message
[GStreamer] WebVTT caps changed in GStreamer 1.14
https://bugs.webkit.org/show_bug.cgi?id=182690
Reviewed by Xabier Rodriguez-Calvar.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Use
text/vtt caps only for GStreamer versions inferior or equal to
1.12. In 1.13 (current git master) the VTT caps format changed to
application/x-subtitle-vtt.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (228507 => 228508)
--- trunk/Source/WebCore/ChangeLog 2018-02-15 10:10:21 UTC (rev 228507)
+++ trunk/Source/WebCore/ChangeLog 2018-02-15 10:11:26 UTC (rev 228508)
@@ -1,3 +1,16 @@
+2018-02-15 Philippe Normand <[email protected]>
+
+ [GStreamer] WebVTT caps changed in GStreamer 1.14
+ https://bugs.webkit.org/show_bug.cgi?id=182690
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Use
+ text/vtt caps only for GStreamer versions inferior or equal to
+ 1.12. In 1.13 (current git master) the VTT caps format changed to
+ application/x-subtitle-vtt.
+
2018-02-15 Zan Dobersek <[email protected]>
HarfBuzzFace should not be ref-counted
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (228507 => 228508)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-02-15 10:10:21 UTC (rev 228507)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-02-15 10:11:26 UTC (rev 228508)
@@ -2166,7 +2166,11 @@
m_textAppSinkPad = adoptGRef(gst_element_get_static_pad(m_textAppSink.get(), "sink"));
ASSERT(m_textAppSinkPad);
- GRefPtr<GstCaps> textCaps = adoptGRef(gst_caps_new_empty_simple("text/vtt"));
+ GRefPtr<GstCaps> textCaps;
+ if (webkitGstCheckVersion(1, 13, 0))
+ textCaps = adoptGRef(gst_caps_new_empty_simple("application/x-subtitle-vtt"));
+ else
+ textCaps = adoptGRef(gst_caps_new_empty_simple("text/vtt"));
g_object_set(m_textAppSink.get(), "emit-signals", TRUE, "enable-last-sample", FALSE, "caps", textCaps.get(), nullptr);
g_signal_connect_swapped(m_textAppSink.get(), "new-sample", G_CALLBACK(newTextSampleCallback), this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
