Title: [228512] trunk/Tools
- Revision
- 228512
- Author
- [email protected]
- Date
- 2018-02-15 08:49:01 -0800 (Thu, 15 Feb 2018)
Log Message
run-jsc-stress-tests - skip a test if any of the run commands evals to skip
https://bugs.webkit.org/show_bug.cgi?id=182729
If multiple run commands are specified and one of them evals to skip,
then the test is not skipped, because the run is scheduled while
evaluating other commands.
Remember if the test is going to be skipped - if yes, just stop
evaluating the other run commands.
Reviewed by Saam Barati.
* Scripts/run-jsc-stress-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (228511 => 228512)
--- trunk/Tools/ChangeLog 2018-02-15 16:06:54 UTC (rev 228511)
+++ trunk/Tools/ChangeLog 2018-02-15 16:49:01 UTC (rev 228512)
@@ -1,3 +1,19 @@
+2018-02-15 Tomas Popela <[email protected]>
+
+ run-jsc-stress-tests - skip a test if any of the run commands evals to skip
+ https://bugs.webkit.org/show_bug.cgi?id=182729
+
+ If multiple run commands are specified and one of them evals to skip,
+ then the test is not skipped, because the run is scheduled while
+ evaluating other commands.
+
+ Remember if the test is going to be skipped - if yes, just stop
+ evaluating the other run commands.
+
+ Reviewed by Saam Barati.
+
+ * Scripts/run-jsc-stress-tests:
+
2018-02-14 Charlie Turner <[email protected]>
Get Garden-O-Matic running again.
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (228511 => 228512)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2018-02-15 16:06:54 UTC (rev 228511)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2018-02-15 16:49:01 UTC (rev 228512)
@@ -536,6 +536,7 @@
def parseRunCommands
oldDidAddRunCommand = $didAddRunCommand
$didAddRunCommand = false
+ $skipped = false
Dir.chdir($outputDir) {
File.open($benchmarkDirectory + $benchmark) {
@@ -551,6 +552,9 @@
end
next unless doesMatch
eval $~.post_match
+ if $skipped
+ break
+ end
}
}
}
@@ -1356,6 +1360,7 @@
def skip
$didAddRunCommand = true
+ $skipped = true
puts "Skipping #{$collectionName}/#{$benchmark}"
end
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
