Title: [228560] trunk
- Revision
- 228560
- Author
- [email protected]
- Date
- 2018-02-16 09:41:12 -0800 (Fri, 16 Feb 2018)
Log Message
IndexedDB: Several test crash in when destroying a IDBKeyData
https://bugs.webkit.org/show_bug.cgi?id=167576
Patch by Fujii Hironori <[email protected]> on 2018-02-16
Reviewed by Michael Catanzaro.
Source/WebCore:
IDBKeyDataHashTraits::constructDeletedValue is using operator= to
assign deletedValue. But, the value is destructed just before
calling constructDeletedValue. You can't use operator= for a
destructed value.
No new tests (Covered by existing tests).
* Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyDataHashTraits::constructDeletedValue):
Construct null value before assigning deletedValue.
LayoutTests:
* platform/gtk/TestExpectations: Unmarked
imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html,
imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html
and storage/indexeddb/modern/index-3-private.html.
* platform/wpe/TestExpectations: Unmarked
imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html and
imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (228559 => 228560)
--- trunk/LayoutTests/ChangeLog 2018-02-16 15:13:31 UTC (rev 228559)
+++ trunk/LayoutTests/ChangeLog 2018-02-16 17:41:12 UTC (rev 228560)
@@ -1,3 +1,18 @@
+2018-02-16 Fujii Hironori <[email protected]>
+
+ IndexedDB: Several test crash in when destroying a IDBKeyData
+ https://bugs.webkit.org/show_bug.cgi?id=167576
+
+ Reviewed by Michael Catanzaro.
+
+ * platform/gtk/TestExpectations: Unmarked
+ imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html,
+ imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html
+ and storage/indexeddb/modern/index-3-private.html.
+ * platform/wpe/TestExpectations: Unmarked
+ imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html and
+ imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html.
+
2018-02-16 Claudio Saavedra <[email protected]>
[WPE] Update expectations for a couple of flaky tests
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (228559 => 228560)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-16 15:13:31 UTC (rev 228559)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-16 17:41:12 UTC (rev 228560)
@@ -1295,10 +1295,6 @@
webkit.org/b/163782 media/video-played-ranges-1.html [ Crash Pass ]
-webkit.org/b/167576 imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html [ Crash Timeout ]
-webkit.org/b/167576 imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html [ Crash Timeout ]
-webkit.org/b/167576 storage/indexeddb/modern/index-3-private.html [ Crash ]
-
webkit.org/b/169811 fast/mediastream/captureStream/canvas2d.html [ Crash Timeout ]
webkit.org/b/169811 fast/mediastream/captureStream/canvas3d.html [ Crash Timeout ]
Modified: trunk/LayoutTests/platform/wpe/TestExpectations (228559 => 228560)
--- trunk/LayoutTests/platform/wpe/TestExpectations 2018-02-16 15:13:31 UTC (rev 228559)
+++ trunk/LayoutTests/platform/wpe/TestExpectations 2018-02-16 17:41:12 UTC (rev 228560)
@@ -417,10 +417,6 @@
# Flaky
webkit.org/b/177530 imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm [ Pass Failure ]
-
-webkit.org/b/167576 imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html [ Crash ]
-webkit.org/b/167576 imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html [ Crash ]
-
webkit.org/b/174354 imported/w3c/IndexedDB-private-browsing/idbfactory_open.html [ Crash Pass ]
webkit.org/b/174354 imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html [ Crash Pass ]
Modified: trunk/Source/WebCore/ChangeLog (228559 => 228560)
--- trunk/Source/WebCore/ChangeLog 2018-02-16 15:13:31 UTC (rev 228559)
+++ trunk/Source/WebCore/ChangeLog 2018-02-16 17:41:12 UTC (rev 228560)
@@ -1,3 +1,21 @@
+2018-02-16 Fujii Hironori <[email protected]>
+
+ IndexedDB: Several test crash in when destroying a IDBKeyData
+ https://bugs.webkit.org/show_bug.cgi?id=167576
+
+ Reviewed by Michael Catanzaro.
+
+ IDBKeyDataHashTraits::constructDeletedValue is using operator= to
+ assign deletedValue. But, the value is destructed just before
+ calling constructDeletedValue. You can't use operator= for a
+ destructed value.
+
+ No new tests (Covered by existing tests).
+
+ * Modules/indexeddb/IDBKeyData.h:
+ (WebCore::IDBKeyDataHashTraits::constructDeletedValue):
+ Construct null value before assigning deletedValue.
+
2018-02-16 Zalan Bujtas <[email protected]>
[RenderTreeBuilder] Move RenderBlock/RenderBlockFlow::addChild() to RenderTreeBuilder
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h (228559 => 228560)
--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h 2018-02-16 15:13:31 UTC (rev 228559)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h 2018-02-16 17:41:12 UTC (rev 228560)
@@ -208,6 +208,7 @@
static void constructDeletedValue(IDBKeyData& key)
{
+ new (&key) IDBKeyData;
key = IDBKeyData::deletedValue();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
