Title: [100847] trunk
- Revision
- 100847
- Author
- [email protected]
- Date
- 2011-11-18 22:05:05 -0800 (Fri, 18 Nov 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=72591
Remove document.width / document.height
Patch by Vineet Chaudhary <[email protected]> on 2011-11-18
Reviewed by Darin Adler.
Source/WebCore:
Removed document.width/document.height from JS bindings,
but keeping the same for ObjC bindings. Also it should use
document.body.clientWidth and document.body.clientHeight instead.
* html/HTMLDocument.idl:
LayoutTests:
As support for document.width / document.height has been
removed it should use document.body.clientWidth and document.body.clientHeight
respectively.
* fast/dom/document-width-height-force-layout-expected.txt:
* fast/dom/document-width-height-force-layout.html:
Modified test case to use document.body.clientWidth and document.body.clientHeight.
* fullscreen/video-specified-size-expected.txt:
* fullscreen/video-specified-size.html:
Modified test case to use document.body.clientWidth.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (100846 => 100847)
--- trunk/LayoutTests/ChangeLog 2011-11-19 05:24:30 UTC (rev 100846)
+++ trunk/LayoutTests/ChangeLog 2011-11-19 06:05:05 UTC (rev 100847)
@@ -1,3 +1,21 @@
+2011-11-18 Vineet Chaudhary <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=72591
+ Remove document.width / document.height
+
+ Reviewed by Darin Adler.
+
+ As support for document.width / document.height has been
+ removed it should use document.body.clientWidth and document.body.clientHeight
+ respectively.
+
+ * fast/dom/document-width-height-force-layout-expected.txt:
+ * fast/dom/document-width-height-force-layout.html:
+ Modified test case to use document.body.clientWidth and document.body.clientHeight.
+ * fullscreen/video-specified-size-expected.txt:
+ * fullscreen/video-specified-size.html:
+ Modified test case to use document.body.clientWidth.
+
2011-11-18 Yuta Kitamura <[email protected]>
[Qt] Unreviewed, add one failing test to the Skipped list.
Modified: trunk/LayoutTests/fast/dom/document-width-height-force-layout-expected.txt (100846 => 100847)
--- trunk/LayoutTests/fast/dom/document-width-height-force-layout-expected.txt 2011-11-19 05:24:30 UTC (rev 100846)
+++ trunk/LayoutTests/fast/dom/document-width-height-force-layout-expected.txt 2011-11-19 06:05:05 UTC (rev 100847)
@@ -1,5 +1,5 @@
-This tests that document.width and document.height cause a layout on use. The test has passed if they have positive values.
+This tests that document.body.clientWidth and document.body.clientHeight cause a layout on use. The test has passed if they have positive values.
-document.width = 800
-document.height = 600
+document.body.clientWidth = 800
+document.body.clientHeight = 600
Modified: trunk/LayoutTests/fast/dom/document-width-height-force-layout.html (100846 => 100847)
--- trunk/LayoutTests/fast/dom/document-width-height-force-layout.html 2011-11-19 05:24:30 UTC (rev 100846)
+++ trunk/LayoutTests/fast/dom/document-width-height-force-layout.html 2011-11-19 06:05:05 UTC (rev 100847)
@@ -11,13 +11,13 @@
if (window.layoutTestController)
layoutTestController.dumpAsText();
- log("document.width = " + document.width);
- log("document.height = " + document.height);
+ log("document.body.clientWidth = " + document.body.clientWidth);
+ log("document.body.clientHeight = " + document.body.clientHeight);
}
</script>
</head>
<body _onload_="test()">
- <p>This tests that document.width and document.height cause a layout on use. The test has passed if they have positive values.</p>
+ <p>This tests that document.body.clientWidth and document.body.clientHeight cause a layout on use. The test has passed if they have positive values.</p>
<pre id="console"></pre>
</body>
</html>
Modified: trunk/LayoutTests/fullscreen/video-specified-size-expected.txt (100846 => 100847)
--- trunk/LayoutTests/fullscreen/video-specified-size-expected.txt 2011-11-19 05:24:30 UTC (rev 100846)
+++ trunk/LayoutTests/fullscreen/video-specified-size-expected.txt 2011-11-19 06:05:05 UTC (rev 100847)
@@ -1,3 +1,3 @@
-EVENT(webkitfullscreenchange) TEST(video.clientWidth==document.width) OK
+EVENT(webkitfullscreenchange) TEST(video.clientWidth==document.body.clientWidth) OK
END OF TEST
Modified: trunk/LayoutTests/fullscreen/video-specified-size.html (100846 => 100847)
--- trunk/LayoutTests/fullscreen/video-specified-size.html 2011-11-19 05:24:30 UTC (rev 100846)
+++ trunk/LayoutTests/fullscreen/video-specified-size.html 2011-11-19 06:05:05 UTC (rev 100847)
@@ -5,14 +5,13 @@
<script>
setSrcById("video", findMediaFile("video", "../media/content/test"));
var video = document.getElementById('video');
-
// Bail out early if the full screen API is not enabled or is missing:
if (Element.prototype.webkitRequestFullScreen == undefined) {
logResult(false, "Element.prototype.webkitRequestFullScreen == undefined");
endTest();
} else {
- waitForEventTestAndEnd(document, 'webkitfullscreenchange', "video.clientWidth==document.width");
+ waitForEventTestAndEnd(document, 'webkitfullscreenchange', "video.clientWidth==document.body.clientWidth");
runWithKeyDown(function(){video.webkitRequestFullScreen()});
}
</script>
-</body>
\ No newline at end of file
+</body>
Modified: trunk/Source/WebCore/ChangeLog (100846 => 100847)
--- trunk/Source/WebCore/ChangeLog 2011-11-19 05:24:30 UTC (rev 100846)
+++ trunk/Source/WebCore/ChangeLog 2011-11-19 06:05:05 UTC (rev 100847)
@@ -1,3 +1,16 @@
+2011-11-18 Vineet Chaudhary <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=72591
+ Remove document.width / document.height
+
+ Reviewed by Darin Adler.
+
+ Removed document.width/document.height from JS bindings,
+ but keeping the same for ObjC bindings. Also it should use
+ document.body.clientWidth and document.body.clientHeight instead.
+
+ * html/HTMLDocument.idl:
+
2011-11-18 Martin Robinson <[email protected]>
Fix the GTK+ build.
Modified: trunk/Source/WebCore/html/HTMLDocument.idl (100846 => 100847)
--- trunk/Source/WebCore/html/HTMLDocument.idl 2011-11-19 05:24:30 UTC (rev 100846)
+++ trunk/Source/WebCore/html/HTMLDocument.idl 2011-11-19 06:05:05 UTC (rev 100847)
@@ -44,8 +44,10 @@
void captureEvents();
void releaseEvents();
+#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
readonly attribute long width;
readonly attribute long height;
+#endif
attribute [ConvertNullToNullString] DOMString dir;
attribute [ConvertNullToNullString] DOMString designMode;
readonly attribute DOMString compatMode;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
