Title: [229736] trunk/Source/WebKit
- Revision
- 229736
- Author
- cdu...@apple.com
- Date
- 2018-03-19 19:34:25 -0700 (Mon, 19 Mar 2018)
Log Message
WKWebView.ClearAppCache is a flaky API test failure on High Sierra.
https://bugs.webkit.org/show_bug.cgi?id=181546
<rdar://problem/36444327>
Reviewed by Ryosuke Niwa.
in LocalStorageDatabaseTracker::deleteDatabasesModifiedSince(), add origin
to originIdentifiersToDelete if we cannot determine the last modification
time of the database file. This likely means the database file does not
exist. However, we still needs to make sure the origin gets removed from
the origins database and there may be *.wal / *.shm variants of the database
that are still on disk and need to be deleted.
* UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::deleteDatabasesModifiedSince):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (229735 => 229736)
--- trunk/Source/WebKit/ChangeLog 2018-03-20 02:31:47 UTC (rev 229735)
+++ trunk/Source/WebKit/ChangeLog 2018-03-20 02:34:25 UTC (rev 229736)
@@ -1,5 +1,23 @@
2018-03-19 Chris Dumez <cdu...@apple.com>
+ WKWebView.ClearAppCache is a flaky API test failure on High Sierra.
+ https://bugs.webkit.org/show_bug.cgi?id=181546
+ <rdar://problem/36444327>
+
+ Reviewed by Ryosuke Niwa.
+
+ in LocalStorageDatabaseTracker::deleteDatabasesModifiedSince(), add origin
+ to originIdentifiersToDelete if we cannot determine the last modification
+ time of the database file. This likely means the database file does not
+ exist. However, we still needs to make sure the origin gets removed from
+ the origins database and there may be *.wal / *.shm variants of the database
+ that are still on disk and need to be deleted.
+
+ * UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
+ (WebKit::LocalStorageDatabaseTracker::deleteDatabasesModifiedSince):
+
+2018-03-19 Chris Dumez <cdu...@apple.com>
+
Have one service worker process per security origin
https://bugs.webkit.org/show_bug.cgi?id=183600
<rdar://problem/35280128>
Modified: trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp (229735 => 229736)
--- trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp 2018-03-20 02:31:47 UTC (rev 229735)
+++ trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp 2018-03-20 02:34:25 UTC (rev 229736)
@@ -152,10 +152,7 @@
String filePath = pathForDatabaseWithOriginIdentifier(origin);
auto modificationTime = FileSystem::getFileModificationTime(filePath);
- if (!modificationTime)
- continue;
-
- if (modificationTime.value() >= time)
+ if (!modificationTime || modificationTime.value() >= time)
originIdentifiersToDelete.append(origin);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
