Title: [229874] trunk/Source/WebInspectorUI
- Revision
- 229874
- Author
- nvasil...@apple.com
- Date
- 2018-03-22 18:00:43 -0700 (Thu, 22 Mar 2018)
Log Message
Uncaught Exception: TypeError: this._textEditor.toggleUnexecutedCodeHighlights().then is not a function
https://bugs.webkit.org/show_bug.cgi?id=181912
<rdar://problem/36700022>
Reviewed by Matt Baker.
The uncaught exception was caused by returning `false` instead of a promise object.
This patch only fixes the exception. Further enhancements should be done in <https://webkit.org/b/183887>.
* UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WI.SourceCodeTextEditor.prototype.toggleUnexecutedCodeHighlights):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (229873 => 229874)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-03-23 00:18:49 UTC (rev 229873)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-03-23 01:00:43 UTC (rev 229874)
@@ -1,3 +1,18 @@
+2018-03-22 Nikita Vasilyev <nvasil...@apple.com>
+
+ Uncaught Exception: TypeError: this._textEditor.toggleUnexecutedCodeHighlights().then is not a function
+ https://bugs.webkit.org/show_bug.cgi?id=181912
+ <rdar://problem/36700022>
+
+ Reviewed by Matt Baker.
+
+ The uncaught exception was caused by returning `false` instead of a promise object.
+ This patch only fixes the exception. Further enhancements should be done in <https://webkit.org/b/183887>.
+
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WI.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
+ (WI.SourceCodeTextEditor.prototype.toggleUnexecutedCodeHighlights):
+
2018-03-20 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: Styles: Loses focus when editing a property while page is being loaded
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (229873 => 229874)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2018-03-23 00:18:49 UTC (rev 229873)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2018-03-23 01:00:43 UTC (rev 229874)
@@ -309,7 +309,7 @@
toggleTypeAnnotations()
{
if (!this._typeTokenAnnotator)
- return false;
+ return Promise.reject(new Error("TypeTokenAnnotator is not initialized."));
var newActivatedState = !this._typeTokenAnnotator.isActive();
if (newActivatedState && this._isProbablyMinified && !this.formatted) {
@@ -325,7 +325,7 @@
toggleUnexecutedCodeHighlights()
{
if (!this._basicBlockAnnotator)
- return false;
+ return Promise.reject(new Error("BasicBlockAnnotator is not initialized."));
let newActivatedState = !this._basicBlockAnnotator.isActive();
if (newActivatedState && this._isProbablyMinified && !this.formatted) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes