Title: [230307] trunk/Source/WebKit
- Revision
- 230307
- Author
- you...@apple.com
- Date
- 2018-04-05 10:43:35 -0700 (Thu, 05 Apr 2018)
Log Message
WebRTC data channel only applications require capture permissions for direct connections
https://bugs.webkit.org/show_bug.cgi?id=174500
<rdar://problem/34134281>
Unreviewed.
Changed the code to suppress: "error: unused variable 'error' [-Werror,-Wunused-variable]"
Added some logging to this error case as a side bonus.
* NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::NetworkMDNSRegister::registerMDNSName):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (230306 => 230307)
--- trunk/Source/WebKit/ChangeLog 2018-04-05 17:37:49 UTC (rev 230306)
+++ trunk/Source/WebKit/ChangeLog 2018-04-05 17:43:35 UTC (rev 230307)
@@ -1,3 +1,16 @@
+2018-04-05 Youenn Fablet <you...@apple.com>
+
+ WebRTC data channel only applications require capture permissions for direct connections
+ https://bugs.webkit.org/show_bug.cgi?id=174500
+ <rdar://problem/34134281>
+
+ Unreviewed.
+ Changed the code to suppress: "error: unused variable 'error' [-Werror,-Wunused-variable]"
+ Added some logging to this error case as a side bonus.
+
+ * NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
+ (WebKit::NetworkMDNSRegister::registerMDNSName):
+
2018-04-05 Carlos Garcia Campos <cgar...@igalia.com>
REGRESSION(r229831): Test WebKit2.ProvisionalURLAfterWillSendRequestCallback times out since r229831
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp (230306 => 230307)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp 2018-04-05 17:37:49 UTC (rev 230306)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp 2018-04-05 17:43:35 UTC (rev 230307)
@@ -97,11 +97,15 @@
DNSServiceRef service;
auto iterator = m_services.find(documentIdentifier);
if (iterator == m_services.end()) {
- if (auto error = DNSServiceCreateConnection(&service)) {
+ auto error = DNSServiceCreateConnection(&service);
+ if (error) {
+ RELEASE_LOG_IF_ALLOWED(sessionID, "registerMDNSName DNSServiceCreateConnection error %d", error);
m_connection.connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { requestIdentifier, makeUnexpected(MDNSRegisterError::DNSSD) }, 0);
return;
}
- if (auto error = DNSServiceSetDispatchQueue(service, dispatch_get_main_queue())) {
+ error = DNSServiceSetDispatchQueue(service, dispatch_get_main_queue());
+ if (error) {
+ RELEASE_LOG_IF_ALLOWED(sessionID, "registerMDNSName DNSServiceCreateConnection error %d", error);
m_connection.connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { requestIdentifier, makeUnexpected(MDNSRegisterError::DNSSD) }, 0);
return;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
