Title: [230405] releases/WebKitGTK/webkit-2.20/Source/bmalloc
- Revision
- 230405
- Author
- carlo...@webkit.org
- Date
- 2018-04-09 05:13:51 -0700 (Mon, 09 Apr 2018)
Log Message
Merge r229669 - Improve error message when Gigacage cannot allocate virtual memory
https://bugs.webkit.org/show_bug.cgi?id=183329
Reviewed by Filip Pizlo.
We've discovered that Deja Dup monitor sets a virtual memory limit, breaking Gigacage. Since
it runs in the background on a fresh out-of-the-box install of Ubuntu, this is not good.
That will have to be fixed by Deja Dup, but there is concern that other applications might
try this, or that users will set a virtual memory limit for the entire desktop session. Of
particular concern is the possibility that users might have copypasted a ulimit line into
a session startup script without understanding it. Let's try to make it slightly easier to
understand what's going wrong.
* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.20/Source/bmalloc/ChangeLog (230404 => 230405)
--- releases/WebKitGTK/webkit-2.20/Source/bmalloc/ChangeLog 2018-04-09 12:13:44 UTC (rev 230404)
+++ releases/WebKitGTK/webkit-2.20/Source/bmalloc/ChangeLog 2018-04-09 12:13:51 UTC (rev 230405)
@@ -1,3 +1,21 @@
+2018-03-16 Michael Catanzaro <mcatanz...@igalia.com>
+
+ Improve error message when Gigacage cannot allocate virtual memory
+ https://bugs.webkit.org/show_bug.cgi?id=183329
+
+ Reviewed by Filip Pizlo.
+
+ We've discovered that Deja Dup monitor sets a virtual memory limit, breaking Gigacage. Since
+ it runs in the background on a fresh out-of-the-box install of Ubuntu, this is not good.
+ That will have to be fixed by Deja Dup, but there is concern that other applications might
+ try this, or that users will set a virtual memory limit for the entire desktop session. Of
+ particular concern is the possibility that users might have copypasted a ulimit line into
+ a session startup script without understanding it. Let's try to make it slightly easier to
+ understand what's going wrong.
+
+ * bmalloc/Gigacage.cpp:
+ (Gigacage::ensureGigacage):
+
2018-02-05 JF Bastien <jfbast...@apple.com>
Gigacage: enable only for WebContent process and token executables
Modified: releases/WebKitGTK/webkit-2.20/Source/bmalloc/bmalloc/Gigacage.cpp (230404 => 230405)
--- releases/WebKitGTK/webkit-2.20/Source/bmalloc/bmalloc/Gigacage.cpp 2018-04-09 12:13:44 UTC (rev 230404)
+++ releases/WebKitGTK/webkit-2.20/Source/bmalloc/bmalloc/Gigacage.cpp 2018-04-09 12:13:51 UTC (rev 230405)
@@ -151,6 +151,7 @@
if (GIGACAGE_ALLOCATION_CAN_FAIL)
return;
fprintf(stderr, "FATAL: Could not allocate gigacage memory with maxAlignment = %lu, totalSize = %lu.\n", maxAlignment, totalSize);
+ fprintf(stderr, "(Make sure you have not set a virtual memory limit.)\n");
BCRASH();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
