Title: [230554] trunk
Revision
230554
Author
cdu...@apple.com
Date
2018-04-11 20:55:51 -0700 (Wed, 11 Apr 2018)

Log Message

input.webkitEntries does not work as expected when folder contains accented chars
https://bugs.webkit.org/show_bug.cgi?id=184517
<rdar://problem/39265537>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Use String::fromUTF8() to construct a WTF String from the char* returned by
dirname() in FileSystem::directoryName(). Previously, we were just calling
the String constructor, which would treat the input as latin 1 instead of
UTF-8.

Test: fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html

* platform/posix/FileSystemPOSIX.cpp:
(WebCore::FileSystem::directoryName):

LayoutTests:

Add layout test coverage.

* fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt: Added.
* fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (230553 => 230554)


--- trunk/LayoutTests/ChangeLog	2018-04-12 02:44:06 UTC (rev 230553)
+++ trunk/LayoutTests/ChangeLog	2018-04-12 03:55:51 UTC (rev 230554)
@@ -1,3 +1,16 @@
+2018-04-11  Chris Dumez  <cdu...@apple.com>
+
+        input.webkitEntries does not work as expected when folder contains accented chars
+        https://bugs.webkit.org/show_bug.cgi?id=184517
+        <rdar://problem/39265537>
+
+        Reviewed by Ryosuke Niwa.
+
+        Add layout test coverage.
+
+        * fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt: Added.
+        * fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html: Added.
+
 2018-04-11  Youenn Fablet  <you...@apple.com>
 
         Preventively expect UTF8 strings from libwebrtc SDP and error messages
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to