Title: [230600] trunk/Source/WebKit
- Revision
- 230600
- Author
- [email protected]
- Date
- 2018-04-12 14:58:54 -0700 (Thu, 12 Apr 2018)
Log Message
[Extra zoom mode] Suppress UI for inputs of type file in extra zoom mode
https://bugs.webkit.org/show_bug.cgi?id=184556
<rdar://problem/39062239>
Reviewed by Andy Estes.
When running in this mode, we don't have the facilities to present document picker UI. For now, just make this
feature fail gracefully.
* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel presentWithParameters:resultListener:]):
(-[WKFileUploadPanel platformSupportsPickerViewController]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (230599 => 230600)
--- trunk/Source/WebKit/ChangeLog 2018-04-12 21:39:27 UTC (rev 230599)
+++ trunk/Source/WebKit/ChangeLog 2018-04-12 21:58:54 UTC (rev 230600)
@@ -1,3 +1,18 @@
+2018-04-12 Wenson Hsieh <[email protected]>
+
+ [Extra zoom mode] Suppress UI for inputs of type file in extra zoom mode
+ https://bugs.webkit.org/show_bug.cgi?id=184556
+ <rdar://problem/39062239>
+
+ Reviewed by Andy Estes.
+
+ When running in this mode, we don't have the facilities to present document picker UI. For now, just make this
+ feature fail gracefully.
+
+ * UIProcess/ios/forms/WKFileUploadPanel.mm:
+ (-[WKFileUploadPanel presentWithParameters:resultListener:]):
+ (-[WKFileUploadPanel platformSupportsPickerViewController]):
+
2018-04-12 Megan Gardner <[email protected]>
Remove block selection code
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm (230599 => 230600)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2018-04-12 21:39:27 UTC (rev 230599)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2018-04-12 21:58:54 UTC (rev 230600)
@@ -243,6 +243,11 @@
_mediaCaptureType = parameters->mediaCaptureType();
#endif
+ if (![self platformSupportsPickerViewController]) {
+ [self _cancel];
+ return;
+ }
+
if ([self _shouldMediaCaptureOpenMediaDevice]) {
[self _adjustMediaCaptureType];
@@ -702,6 +707,15 @@
[self _uploadItemForJPEGRepresentationOfImage:originalImage successBlock:successBlock failureBlock:failureBlock];
}
+- (BOOL)platformSupportsPickerViewController
+{
+#if ENABLE(EXTRA_ZOOM_MODE)
+ return NO;
+#else
+ return YES;
+#endif
+}
+
@end
#pragma clang diagnostic pop
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
